feat: add support for Non-interactive PoRep #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for ni-porep. It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those. The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API). Changes on the CI are: - Makes it match the Rust version in the rust-toolchain.toml - Newer Go version (1.21) on all platforms - Larger instance for the testsas the Ni-PoRep synthesis phase takes more resources. Closes #453, #456, #458.
rjan90
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
I have done a review of the things that I have knowledge about, so it would be great to have someone else 👀 and ✅ on this as well. But:
- The constants in
cgo/const.golooks correct. - It now uses the GST
v0.14.0-rc1which is the first GST release candidate for nv23. - fvm4, fvm4_shared points to the latests versions.
This was referenced Jun 13, 2024
Closed
This way, all FVM versions us the same proofs libraries.
|
I pushed one more commit to update FVM v2 & v3 to remove the old proofs code from the build tree. |
Stebalien
approved these changes
Jun 14, 2024
|
I've pushed a new commit, which patches rust-fil-proofs, so that the code can be tested even without a release. This is a temporary solution, but it should keep things going. |
cryptonemo
reviewed
Jun 18, 2024
cryptonemo
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for ni-porep.
It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those.
The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API).
Changes on the CI are:
Closes #453, #456, #458.
I made a new PR containing all changes to make things easier to follow and review.
What is still missing is a new
rust-fil-proofsrelease containing filecoin-project/rust-fil-proofs#1758. To keep things simple, it'll probably be a patch release, so the only thing that we'll need will be updating theCargo.lockof thefilecoin-ffi.