Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip changelog]: Update CircleCI config for arm64 #465

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[skip changelog]: Update CircleCI config for arm64 #465

merged 2 commits into from
Jul 10, 2024

Conversation

aarshkshah1992
Copy link
Contributor

No description provided.

@aarshkshah1992 aarshkshah1992 requested a review from rvagg July 8, 2024 11:25
rvagg
rvagg reviewed Jul 9, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Jul 9, 2024

@aarshkshah1992 @rjan90 @LexLuthr I've put DEBIAN_FRONTEND=noninteractive into the filecoin-ffi CircleCI global environment variables settings and re-run the failed release job: https://app.circleci.com/pipelines/github/filecoin-project/filecoin-ffi/3178/workflows/a728964b-2500-4e88-ad6c-3c44250c4e5c and we have the binary on the release now: https://github.com/filecoin-project/filecoin-ffi/releases/tag/e467d2992e3f9bd0

Also confirmed to work re-running a failed PR from yesterday: #466

@LexLuthr
Copy link

LexLuthr commented Jul 9, 2024

The package is there now. This approach works as well.

@aarshkshah1992 @rvagg
Apply suggestions from code review
6de7ec0 
Co-authored-by: Rod Vagg <rod@vagg.org>
@aarshkshah1992 aarshkshah1992 changed the title Update CircleCI config for arm64 [skip_changelog]: Update CircleCI config for arm64 Jul 9, 2024
@rvagg rvagg changed the title [skip_changelog]: Update CircleCI config for arm64 [skip changelog]: Update CircleCI config for arm64 Jul 10, 2024
@rvagg rvagg merged commit 95800b2 into master Jul 10, 2024
9 checks passed
@rvagg rvagg deleted the e467d2992e3f9bd0/fix-arm-64 branch July 10, 2024 02:12
@rjan90 rjan90 mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarshkshah1992 @rvagg @LexLuthr