Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CertStore: Implement a friendlier subscribe method #377

Closed
wants to merge 1 commit into from

Conversation

Stebalien
Copy link
Member

I ended up not needing this but I wanted to get some feedback on it as it's significantly friendlier than the current SubscribeForNewCerts method. Basically, this one doesn't force the subscriber to implement resubscribe/catchup logic manually.

I ended up not needing this but I wanted to get some feedback on it as
it's significantly friendlier than the current `SubscribeForNewCerts` method.
@Stebalien Stebalien requested a review from Kubuxu June 27, 2024 04:48
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (69e5251) to head (a6a90e2).
Report is 183 commits behind head on main.

Files with missing lines Patch % Lines
certstore/certstore.go 0.00% 47 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   83.08%   80.95%   -2.14%     
==========================================
  Files          15       15              
  Lines        1780     1827      +47     
==========================================
  Hits         1479     1479              
- Misses        175      222      +47     
  Partials      126      126              
Files with missing lines Coverage Δ
certstore/certstore.go 52.58% <0.00%> (-12.12%) ⬇️

@Kubuxu
Copy link
Contributor

Kubuxu commented Jul 3, 2024

I feel that in most cases the cert subscriber doesn't care about the complete sequence of certs, only the most recent one. I would for sure keep this branch around though as the code might be useful in the future.

@Stebalien
Copy link
Member Author

Yeah, that's where I ended up. However, light clients (and lotus APIs in general) will likely want this kind of API.

@Stebalien
Copy link
Member Author

Closing in favor of #646. Every time I've wanted to subscribe for certificates, I've only cared about the latest. Especially because certificates are usually stored inside the certstore anyways.

@Stebalien Stebalien closed this Sep 17, 2024
@Stebalien Stebalien deleted the steb/friendly-subscribe branch October 28, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants