Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CertStore subscriber #646

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Simplify CertStore subscriber #646

merged 1 commit into from
Sep 17, 2024

Conversation

Stebalien
Copy link
Member

I have yet to write any code that cares about intermediate certificates and they can easily be queried with GetRange. This change:

  1. Makes the certificate subscription system always return the latest certificate, dropping intermediates.
  2. Drops the dependency on go-broadcast.
  3. Simplifies the code that relies on the certificate subscription logic.

@Stebalien Stebalien force-pushed the steb/simplify-cert-sub branch 2 times, most recently from ad7ff7a to 8b01c73 Compare September 17, 2024 13:53
@Stebalien Stebalien force-pushed the steb/simplify-cert-sub branch 2 times, most recently from 77c01e4 to 2428ed1 Compare September 17, 2024 14:09
I have yet to write any code that cares about intermediate certificates
and they can easily be queried with `GetRange`. This change:

1. Makes the certificate subscription system always return the latest
certificate, dropping intermediates.
2. Drops the dependency on go-broadcast.
3. Simplifies the code that relies on the certificate subscription logic.
@Stebalien Stebalien force-pushed the steb/simplify-cert-sub branch from 2428ed1 to 46ff473 Compare September 17, 2024 14:13
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (92a5658) to head (46ff473).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
certstore/certstore.go 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   80.02%   79.67%   -0.35%     
==========================================
  Files          52       52              
  Lines        4695     4703       +8     
==========================================
- Hits         3757     3747      -10     
- Misses        590      603      +13     
- Partials      348      353       +5     
Files with missing lines Coverage Δ
host.go 69.47% <100.00%> (-1.56%) ⬇️
certstore/certstore.go 68.44% <96.77%> (+2.31%) ⬆️

... and 5 files with indirect coverage changes

@Stebalien Stebalien added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit f49c874 Sep 17, 2024
13 checks passed
@Stebalien Stebalien deleted the steb/simplify-cert-sub branch September 17, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants