Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default Certificate exchange config in local devnet manifest #475

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

masih
Copy link
Member

@masih masih commented Jul 15, 2024

Set the default cert exchange configuration in the local devnet manifest, since nil cert exchange config causes panic.

Relates to: filecoin-project/lotus#12236

Set the default cert exchange configuration in the local devnet
manifest, since nil cert exchange config causes panic.

Relates to: filecoin-project/lotus#12236
@masih masih requested review from Stebalien, Kubuxu and rvagg July 15, 2024 11:54
@masih masih enabled auto-merge July 15, 2024 11:57
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (4aba72e) to head (fa9b753).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   81.77%   81.81%   +0.03%     
==========================================
  Files          41       41              
  Lines        3666     3667       +1     
==========================================
+ Hits         2998     3000       +2     
+ Misses        391      390       -1     
  Partials      277      277              
Files Coverage Δ
manifest/manifest.go 88.46% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

@masih masih added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit d3185ef Jul 15, 2024
13 checks passed
@masih masih deleted the masih/set-default-cx-config-localdevnet branch July 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants