Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: f3: panic on unset manifest properties #12236

Closed
wants to merge 1 commit into from
Closed

fix: f3: panic on unset manifest properties #12236

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 15, 2024 •
edited
Loading

Failing when running off master.

GpbftConfig is now set in go-f3's main branch when calling LocalDevnetManifest(), but CxConfig isn't. Perhaps we can have that set as well and then have an updated tag @masih?

Jul 15 20:05:10 fletcher lotus-calibnet[385671]: github.com/filecoin-project/go-f3.(*F3).resumeInternal(0xc022820790, {0x8b393d0, 0xc022c30f50})
Jul 15 20:05:10 fletcher lotus-calibnet[385671]:         /home/rvagg/go/pkg/mod/github.com/filecoin-project/go-f3@v0.0.3/f3.go:314 +0x1fa
Jul 15 20:05:10 fletcher lotus-calibnet[385671]: github.com/filecoin-project/go-f3.(*F3).reconfigure(0xc022820790, {0x8b393d0?, 0xc022c30fa0?}, 0xc022c31d10)
Jul 15 20:05:10 fletcher lotus-calibnet[385671]:         /home/rvagg/go/pkg/mod/github.com/filecoin-project/go-f3@v0.0.3/f3.go:254 +0x21c
Jul 15 20:05:10 fletcher lotus-calibnet[385671]: github.com/filecoin-project/go-f3.(*F3).Start(0xc022820790, {0x8b393d0, 0xc022c30fa0})
Jul 15 20:05:10 fletcher lotus-calibnet[385671]:         /home/rvagg/go/pkg/mod/github.com/filecoin-project/go-f3@v0.0.3/f3.go:177 +0x193
Jul 15 20:05:10 fletcher lotus-calibnet[385671]: github.com/filecoin-project/lotus/chain/lf3.New.func1()
Jul 15 20:05:10 fletcher lotus-calibnet[385671]:         /home/rvagg/go/src/github.com/filecoin-project/lotus/chain/lf3/f3.go:79 +0x35
Jul 15 20:05:10 fletcher lotus-calibnet[385671]: go.uber.org/fx/internal/lifecycle.Wrap[...].func1()

@rvagg rvagg requested a review from masih July 15, 2024 10:20
@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Jul 15, 2024
@rvagg rvagg mentioned this pull request Jul 15, 2024
Merged
masih added a commit to filecoin-project/go-f3 that referenced this pull request Jul 15, 2024
@masih
Set default Certificate exchange config in local devnet manifest
fa9b753 
Set the default cert exchange configuration in the local devnet
manifest, since nil cert exchange config causes panic.

Relates to: filecoin-project/lotus#12236
@masih masih mentioned this pull request Jul 15, 2024
Merged
github-merge-queue bot pushed a commit to filecoin-project/go-f3 that referenced this pull request Jul 15, 2024
@masih
Set default Certificate exchange config in local devnet manifest (#475)
d3185ef 
Set the default cert exchange configuration in the local devnet
manifest, since nil cert exchange config causes panic.

Relates to: filecoin-project/lotus#12236
@masih masih mentioned this pull request Jul 15, 2024
Merged
8 tasks
masih
masih reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out @rvagg 🙏
go-f3 v0.0.4 is now updated to set default cert exchange config.

I think we can close this PR?

@rvagg rvagg closed this Jul 16, 2024
@rvagg rvagg deleted the rvagg/f3fix branch July 16, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masih masih masih left review comments

Assignees
No one assigned
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @masih