Use latest specs-actors with uint64 lane and nonce from paych.Actor #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The latest specs-actors has the changes to paych.Actor that I introduced in specs-actors PR #157, which makes Lane and Nonce
Uint64s. In going back to retrieval market implementation I saw that go-fil-markets hasn't yet updated to the latest specs-actors. This is blocking me, since my branch is up-to-date with go-filecoin master, which itself uses the latest specs-actors, and now I am seeing test failures which can't be resolved without this update.Solution
Update to latest specs-actors and fix the problems that arise: int64 --> uint64 and rerun cbor-gen.