This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
paych.Actor: convert Lane and Nonce to uint64 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
requested review from
sternhenri,
whyrusleeping and
anorth
and removed request for
sternhenri
shannonwells
changed the title
paych.Actor: convert Lane and Nonce to uint64
anorth
approved these changes
Feb 12, 2020
laser
pushed a commit
that referenced
this pull request
Feb 13, 2020
laser
pushed a commit
that referenced
this pull request
Feb 13, 2020
aarshkshah1992
pushed a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in fil-specs channel, lane and nonce are int64s. Since negative values aren't meaningful, rather than put checks for invalid values in the code, let's eliminate the issue entirely and make them unsigned. This is only for the payment channel actor.