Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieval Market Extraction #13

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Retrieval Market Extraction #13

merged 2 commits into from
Dec 19, 2019

Conversation

hannahhoward
Copy link
Collaborator

Goals

RetreivalMarket out of Lotus

Implementation

hannahhoward and others added 2 commits December 19, 2019 13:58
@hannahhoward @ingar
feat(retrievalmarket): extract from lotus
1b7d1db 
Extract retrievalmarket from lotus, migrate to shared types, use cbor-gen-for, etc
@shannonwells @ingar
Testing refactors (#21)
69eb4d3 
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
ingar
ingar approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Going to merge this to get some traction on the other branches.

@ingar ingar merged commit 920f643 into master Dec 19, 2019
@shannonwells shannonwells deleted the feat/retrieval-extraction branch December 20, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingar ingar ingar approved these changes

@shannonwells shannonwells Awaiting requested review from shannonwells

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahhoward @ingar @shannonwells