-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieval Market Cleanup W/ Node Interfaces #826
Conversation
485fa6b
to
53cc90b
Compare
53cc90b
to
40943c5
Compare
d33ec46
to
6081a88
Compare
40943c5
to
8cd06a5
Compare
6081a88
to
fd2be38
Compare
8cd06a5
to
f699010
Compare
fd2be38
to
463692e
Compare
f699010
to
ec44c96
Compare
463692e
to
a479f65
Compare
ec44c96
to
bd6a32d
Compare
a479f65
to
bf9aa44
Compare
bd6a32d
to
cecce73
Compare
Define all types to spec, modify interfaces, wrap old code fix(builder): use client blockstore for retrieval feat(retrieval): add node implementations add node adapters for client & provider so that retrieval can be extracted
cecce73
to
5b74a71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 Nit
@magik6k lock added Possible gotcha we should keep an eye on: possible solutions include:
I'd recommend just deferring but worth keeping in mind |
Add a mutex to protect access to the subscriber list for retrieval market
6afdd83
to
99309ec
Compare
Goals
This PR is a WIP Branch for extracting the retrieval market to a shared component and updating it to spec.
Implementation
This extraction is based off the existing LOTUS code and V0 of the Filecoin retrieval spec: https://filecoin-project.github.io/specs/#systems__filecoin_markets__retrieval_market
The retrieval market extraction plan has a few distinct steps:
This initial extraction does the first two steps.
This means that internal to the module, the old data types and protocols still exists (i.e. we have not done step 3) and there is translation back and forth which makes the implementation slightly awkward.
fixes filecoin-project/go-retrieval-market-project#1
fixes filecoin-project/go-retrieval-market-project#2
fixes filecoin-project/go-retrieval-market-project#3
fixes filecoin-project/go-retrieval-market-project#4