Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract Provider piece logic to separate file #750

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 13, 2022

Based on feedback in #749, which applied to #747 which was already merged.

also includes:

  • fix: handle error AND zero-length cases from piece lookup

@rvagg rvagg requested a review from dirkmc September 13, 2022 09:27
@rvagg rvagg force-pushed the rvagg/provider-piece-separation branch from b78ab9f to 7578174 Compare September 13, 2022 09:27
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #750 (e051f00) into master (787c67b) will increase coverage by 0.38%.
The diff coverage is 71.16%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   57.59%   57.97%   +0.38%     
==========================================
  Files          65       66       +1     
  Lines        5474     5540      +66     
==========================================
+ Hits         3152     3211      +59     
- Misses       1973     1979       +6     
- Partials      349      350       +1     
Impacted Files Coverage Δ
storagemarket/impl/provider_environments.go 10.38% <0.00%> (+3.11%) ⬆️
storagemarket/impl/providerstates/provider_fsm.go 74.60% <ø> (ø)
storagemarket/impl/provider.go 26.50% <7.15%> (-0.13%) ⬇️
retrievalmarket/impl/provider_environments.go 66.67% <46.16%> (-2.38%) ⬇️
retrievalmarket/impl/provider.go 68.33% <66.67%> (-1.20%) ⬇️
retrievalmarket/impl/provider_pieces.go 83.19% <83.19%> (ø)

@rvagg rvagg force-pushed the rvagg/provider-piece-separation branch from 7578174 to e051f00 Compare October 14, 2022 03:21
@dirkmc dirkmc merged commit 2ac8284 into master Oct 14, 2022
@dirkmc dirkmc deleted the rvagg/provider-piece-separation branch October 14, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants