Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipdx: generate formulas based on the new versioning scheme + full automation #19

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

laurentsenta
Copy link
Collaborator

@laurentsenta laurentsenta commented Jul 17, 2024

  • load latest versions automatically from the lotus repository (supports vx.y.z and miner/vx.y.z)
  • update formulas daily / on workflow dispatch if needed
  • new schema to deal with lotus and lotus miner.

demo in:
https://github.com/laurentsenta/homebrew-lotus

workflow run:
https://github.com/laurentsenta/homebrew-lotus/actions/runs/9975325143

pr:
laurentsenta#5

The following test succeeded:

brew install laurentsenta/lotus/lotus
lotus --version

brew install laurentsenta/lotus/lotus-miner
lotus-miner --version
lotus-worker --version

⚠️ for the filecoin team: documentation should be updated to reflect the new packaging scheme.

@laurentsenta laurentsenta force-pushed the ipdx-with-new-release branch 3 times, most recently from d65b325 to af09b7b Compare July 17, 2024 13:19
@laurentsenta laurentsenta marked this pull request as draft July 17, 2024 13:24
@laurentsenta laurentsenta force-pushed the ipdx-with-new-release branch 6 times, most recently from 3da82a5 to 58e08bd Compare July 17, 2024 13:44
@laurentsenta laurentsenta requested a review from galargh July 17, 2024 13:46
@BigLep
Copy link
Member

BigLep commented Aug 16, 2024

There was a miner/ tag (https://github.com/filecoin-project/lotus/releases/tag/miner%2Fv1.28.2) published 2024-08-15, which we believe should help unblock the PR.

@laurentsenta laurentsenta force-pushed the ipdx-with-new-release branch from 58e08bd to a2c30d4 Compare August 26, 2024 08:51
@laurentsenta
Copy link
Collaborator Author

@BigLep @galargh thanks for the notes, with https://github.com/filecoin-project/lotus/releases/tag/miner%2Fv1.28.2 we have an actual release, which gets us further, but it has no binaries.

The script assumes the lotus-miner binary is released (example), without it, we can't download, hash, or publish the artifact URL for brew to install.

laurentsenta added a commit to laurentsenta/github-mgmt-4 that referenced this pull request Sep 18, 2024
BigLep added a commit to filecoin-project/github-mgmt that referenced this pull request Sep 19, 2024
* add laurentsenta to homebrew and docs

See filecoin-project/lotus-docs#746 and filecoin-project/homebrew-lotus#19

* fix@10918087956 [skip fix]

* wrong repo

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: filecoin-project-mgmt-read-write[bot] <124318806+filecoin-project-mgmt-read-write[bot]@users.noreply.github.com>
Co-authored-by: Steve Loeppky <biglep@filoz.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants