Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipdx: auto update docs on version changes (support new release system) #746

Merged
merged 13 commits into from
Sep 25, 2024

Conversation

laurentsenta
Copy link
Collaborator

@laurentsenta laurentsenta commented Jul 9, 2024

Fully automate version changes

  • provide a {{< version >}} shortcode that can be reused accross the repository
  • store the current version (lotus, miner, and go) in a resource file
  • load the lotus-cli and lotus-miner-cli markdown from github on build
  • provide a github workflow to auto-update the versions
    • triggered every morning
    • triggered on workflow_dispatch

(similar to our work on kubo, but even better thanks to Hugo's templating features)

  • test the workflow
  • confirm the latest release from github is the "highest semantic version" -- this is dealt with in @galargh's release PR

Contributes to filecoin-project/lotus#12072

@laurentsenta laurentsenta requested a review from galargh July 9, 2024 08:40
@laurentsenta laurentsenta force-pushed the ipdx-auto-update-docs branch from 39bf050 to 4633938 Compare July 9, 2024 08:40
@laurentsenta
Copy link
Collaborator Author

@laurentsenta laurentsenta changed the title ipdx: auto update docs ipdx: auto update docs on version changes Jul 9, 2024
.github/workflows/update-version.yml Outdated Show resolved Hide resolved
@@ -1,7 +1,7 @@
---
title: "Lotus-miner CLI"
description: "Reference documentation for the lotus-miner command-line interface."
lead: "Reference documentation for the lotus-miner command-line interface. This documentation was automatically generated using Lotus v1.27.0."
lead: "Reference documentation for the lotus-miner command-line interface. This documentation was automatically generated using Lotus latest release."
Copy link

@galargh galargh Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lotus Miner and Lotus Node releases are being split in filecoin-project/lotus#12010

Copy link
Collaborator Author

@laurentsenta laurentsenta Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up, I updated the code to deal with both. I guess we'll have to wait for at least one release to try the workflow end to end.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. Thanks for making the changes.

@laurentsenta laurentsenta changed the title ipdx: auto update docs on version changes ipdx: auto update docs on version changes (support new release system) Jul 9, 2024
@laurentsenta laurentsenta force-pushed the ipdx-auto-update-docs branch from f06bf2e to f31d3cd Compare July 11, 2024 12:10
@laurentsenta
Copy link
Collaborator Author

Tested in laurentsenta#2
With the new versions pulled from https://github.com/galargh/lotus/releases

@laurentsenta
Copy link
Collaborator Author

laurentsenta commented Jul 11, 2024

@galargh we should be able to merge, the workflow will be working as soon as we complete a new release in the lotus repo. Until then the workflow will fail but that won't break the docs.

I spoke too soon, I forgot pulling the miner's doc rely on the new miner/vxxx tag existing too.

@BigLep
Copy link
Member

BigLep commented Aug 16, 2024

@laurentsenta : There was a miner/ tag (https://github.com/filecoin-project/lotus/releases/tag/miner%2Fv1.28.2) published 2024-08-15, which we believe should help unblock the PR.

@laurentsenta laurentsenta force-pushed the ipdx-auto-update-docs branch 2 times, most recently from b9117c0 to 48c55f9 Compare August 26, 2024 09:25
@BigLep
Copy link
Member

BigLep commented Sep 9, 2024

Per 2024-08-26 meeting with IPDX, it was agreed that we should manually create a github release for the miner/v1.28.2 tag. (This was started in https://github.com/filecoin-project/lotus/releases/edit/untagged-53cb53b937b9699b4d38). This unblocks homebrew and this lotus-docs automation.

I believe a Lotus maintainer needs to do this. @rjan90 : are you ok to take it (or we do it in screenshot together)? I'm nervous to personally be doing GitHub releases through the UI without review.

@galargh
Copy link

galargh commented Sep 11, 2024

Per 2024-08-26 meeting with IPDX, it was agreed that we should manually create a github release for the miner/v1.28.2 tag. (This was started in filecoin-project/lotus/releases/edit/untagged-53cb53b937b9699b4d38). This unblocks homebrew and this lotus-docs automation.

I believe a Lotus maintainer needs to do this. @rjan90 : are you ok to take it (or we do it in screenshot together)? I'm nervous to personally be doing GitHub releases through the UI without review.

If you could publish it, that would be great and it'd unblock this PR. I think it'd be better if lotus maintainer was present when that happens in case there's some community communication that needs to happen. You can ping me and we can do it together if you prefer.

@rjan90
Copy link
Collaborator

rjan90 commented Sep 12, 2024

Hey @galargh! I published the miner/v1.28.2 release now: https://github.com/filecoin-project/lotus/releases/tag/miner%2Fv1.28.2.

Let me know if you need any additional things

@laurentsenta
Copy link
Collaborator Author

laurentsenta commented Sep 18, 2024

Team, thanks for the update,

BigLep added a commit to filecoin-project/github-mgmt that referenced this pull request Sep 19, 2024
* add laurentsenta to homebrew and docs

See filecoin-project/lotus-docs#746 and filecoin-project/homebrew-lotus#19

* fix@10918087956 [skip fix]

* wrong repo

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: filecoin-project-mgmt-read-write[bot] <124318806+filecoin-project-mgmt-read-write[bot]@users.noreply.github.com>
Co-authored-by: Steve Loeppky <biglep@filoz.org>
@laurentsenta
Copy link
Collaborator Author

@rjan90 @BigLep I've updated the PR, and we should be ready for review and merge.

Could you double-check, on the preview deploy, that content/en/lotus/manage/lotus-cli.md and content/en/storage-providers/operate/lotus-miner-cli.md are correctly loaded from Github on build.

If that's easier, please feel free to invite me to the fleek project I'll check this myself (firstname @ singulargarden.com)

Copy link
Collaborator

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here looks good! I just need to double-check the preview deploy on Fleek before merging (encountered some issues when trying to log-in)

@rjan90
Copy link
Collaborator

rjan90 commented Sep 25, 2024

Can confirm that I see the changes in the preview deploy on Fleek:

Screenshot 2024-09-25 at 17 06 17 Screenshot 2024-09-25 at 17 06 32 Screenshot 2024-09-25 at 17 08 57

@rjan90 rjan90 merged commit 4f113ca into main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

Automatically update the lotus-miner CLI page
4 participants