-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipdx: auto update docs on version changes (support new release system) #746
Conversation
39bf050
to
4633938
Compare
Test PR: after running a few times: |
@@ -1,7 +1,7 @@ | |||
--- | |||
title: "Lotus-miner CLI" | |||
description: "Reference documentation for the lotus-miner command-line interface." | |||
lead: "Reference documentation for the lotus-miner command-line interface. This documentation was automatically generated using Lotus v1.27.0." | |||
lead: "Reference documentation for the lotus-miner command-line interface. This documentation was automatically generated using Lotus latest release." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lotus Miner and Lotus Node releases are being split in filecoin-project/lotus#12010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up, I updated the code to deal with both. I guess we'll have to wait for at least one release to try the workflow end to end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense. Thanks for making the changes.
f06bf2e
to
f31d3cd
Compare
Tested in laurentsenta#2 |
@galargh I spoke too soon, I forgot pulling the miner's doc rely on the new miner/vxxx tag existing too. |
@laurentsenta : There was a |
b9117c0
to
48c55f9
Compare
Per 2024-08-26 meeting with IPDX, it was agreed that we should manually create a github release for the I believe a Lotus maintainer needs to do this. @rjan90 : are you ok to take it (or we do it in screenshot together)? I'm nervous to personally be doing GitHub releases through the UI without review. |
If you could publish it, that would be great and it'd unblock this PR. I think it'd be better if lotus maintainer was present when that happens in case there's some community communication that needs to happen. You can ping me and we can do it together if you prefer. |
Hey @galargh! I published the Let me know if you need any additional things |
Team, thanks for the update,
|
* add laurentsenta to homebrew and docs See filecoin-project/lotus-docs#746 and filecoin-project/homebrew-lotus#19 * fix@10918087956 [skip fix] * wrong repo --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: filecoin-project-mgmt-read-write[bot] <124318806+filecoin-project-mgmt-read-write[bot]@users.noreply.github.com> Co-authored-by: Steve Loeppky <biglep@filoz.org>
48c55f9
to
b4d2f97
Compare
@rjan90 @BigLep I've updated the PR, and we should be ready for review and merge. Could you double-check, on the preview deploy, that If that's easier, please feel free to invite me to the fleek project I'll check this myself (firstname @ singulargarden.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here looks good! I just need to double-check the preview deploy on Fleek before merging (encountered some issues when trying to log-in)
Fully automate version changes
{{< version >}}
shortcode that can be reused accross the repository(similar to our work on kubo, but even better thanks to Hugo's templating features)
Contributes to filecoin-project/lotus#12072