Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ask for network name in CI input #1611

Closed
Tracked by #1615
masih opened this issue Aug 15, 2024 · 0 comments · Fixed by #1618
Closed
Tracked by #1615

Only ask for network name in CI input #1611

masih opened this issue Aug 15, 2024 · 0 comments · Fixed by #1618
Assignees

Comments

@masih
Copy link
Member

masih commented Aug 15, 2024

Instead of asking for lotus_install_network and lotus_deploy_network, simply ask for network name and infer the other one.

Look at example here, where we only ask the network name, then infer deploy network from it.

This simplifies the UX and avoids error-prone input.

Note the typed GitHub Actions input (i.e. drop-down menu instead of textual input of network name).

@rjan90 rjan90 added this to FilOz Aug 16, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz Aug 16, 2024
@rjan90 rjan90 moved this from 📌 Triage to 🐱Todo in FilOz Aug 28, 2024
@masih masih self-assigned this Aug 28, 2024
masih added a commit that referenced this issue Sep 3, 2024
Infer "deploy network" from a simple network name and use consistent
input naming across jobs.

Fixes #1611
@masih masih moved this from 🐱Todo to ⌨️In Progress in FilOz Sep 3, 2024
@masih masih closed this as completed in 2ace328 Sep 6, 2024
@rjan90 rjan90 moved this from ⌨️In Progress to 🎉 Done in FilOz Sep 12, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️Done (Archive) in FilOz Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging a pull request may close this issue.

1 participant