Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify reset CI parameters #1618

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Simplify reset CI parameters #1618

merged 1 commit into from
Sep 6, 2024

Conversation

masih
Copy link
Member

@masih masih commented Sep 3, 2024

Infer "deploy network" from a simple network name and use consistent input naming across jobs.

Fixes #1611

Infer "deploy network" from a simple network name and use consistent
input naming across jobs.

Fixes #1611
@masih
Copy link
Member Author

masih commented Sep 3, 2024

Dry-run of changes here worked as expected, failing with host being unavailable.

@masih masih requested review from Stebalien and rjan90 September 3, 2024 21:25
@rjan90
Copy link
Contributor

rjan90 commented Sep 6, 2024

I made the instances available, but we are now encountering: Group fc does not exist failures in when trying to do the Dry-run: https://github.com/filecoin-project/lotus-infra/actions/runs/10733831631/job/29767872938.

TASK [common : Ensure login user is added group] *******************************
fatal: [preminer-1.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [scratch-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [bootstrap-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [bootstrap-1.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [toolshed-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [preminer-2.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [preminer-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [toolshed-1.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}

@masih
Copy link
Member Author

masih commented Sep 6, 2024

@rjan90 these are "resumed" instances, not stood up from scratch. Correct?

@rjan90
Copy link
Contributor

rjan90 commented Sep 6, 2024

They are ”stood up from scratch” I think. At least I had to run terraform apply because the recorded where out of date, and in that process it terminated the old instances and created new instances.

@masih
Copy link
Member Author

masih commented Sep 6, 2024

Do you still have the terraform apply logs? If so, I'd like to know how many resources updated vs created vs destroyed.

@rjan90
Copy link
Contributor

rjan90 commented Sep 6, 2024

Sorry that I derailed the PR a bit with an unrelated error. But the changes here looks good to me, and looks and behaves as expected, making running the reset a little less confusing
Screenshot 2024-09-06 at 13 51 43

@masih
Copy link
Member Author

masih commented Sep 6, 2024

No worries. THe issue indeed seems unrelated. Looking into it.

@masih masih merged commit 2ace328 into master Sep 6, 2024
0 of 2 checks passed
@masih masih deleted the masih/no-more-deploy-network branch September 6, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only ask for network name in CI input
2 participants