Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sector import: SectorReceive checks for wrong randomness #11122

Closed
5 of 11 tasks
mtrisic opened this issue Aug 1, 2023 · 1 comment · Fixed by #11123
Closed
5 of 11 tasks

sector import: SectorReceive checks for wrong randomness #11122

mtrisic opened this issue Aug 1, 2023 · 1 comment · Fixed by #11123
Labels
kind/bug Kind: Bug

Comments

@mtrisic
Copy link
Contributor

mtrisic commented Aug 1, 2023

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

Daemon:  1.23.1+2k+git.26dbe515d.dirty+api1.5.0
Local: lotus version 1.23.1+2k+git.26dbe515d.dirty

Repro Steps

  1. Try importing a sector using SAAS API ('SectorReceive rpc method') that is sealed up-to SubmitCommit state.
  2. SectorReceive will fail with an error seeds differ; Miner's log will print out a warning like this one:
WARN	rpc	go-jsonrpc@v0.2.3/handler.go:406	error in RPC call to 'Filecoin.SectorReceive': provided(9e4c4ca02f51a2bb6e0e10eadfb45aedb8f8e56647b744ce4a51f740ca77c963) and generated(e9f8a071b727a51dcf7156a9fce7161b22829ddf79fd80199f0a1f0b37227470) seeds differ:
    github.com/filecoin-project/lotus/storage/pipeline.(*Sealing).checkSectorMeta
        /Users/mladen/Projects/filmineio/lotus/storage/pipeline/receive.go:140

Describe the Bug

Lotus-miner performs a wrong check while importing a sector that is passed a waitseed phase. While sealing a sector Beacon randomness is used, but lotus mistakenly checks for Ticket randomness in sector import. Correct randomness is checked later during workflow, for example inside builtin-actors.

Logging Information

WARN	rpc	go-jsonrpc@v0.2.3/handler.go:406	error in RPC call to 'Filecoin.SectorReceive': provided(9e4c4ca02f51a2bb6e0e10eadfb45aedb8f8e56647b744ce4a51f740ca77c963) and generated(e9f8a071b727a51dcf7156a9fce7161b22829ddf79fd80199f0a1f0b37227470) seeds differ:
    github.com/filecoin-project/lotus/storage/pipeline.(*Sealing).checkSectorMeta
        /Users/mladen/Projects/filmineio/lotus/storage/pipeline/receive.go:140

@mtrisic
Copy link
Contributor Author

mtrisic commented Aug 1, 2023

Info about this issue discussed on Filecoin slack, #fil-lotus-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant