Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sector import: fix evaluating randomness when importing a sector #11123

Conversation

mtrisic
Copy link
Contributor

@mtrisic mtrisic commented Aug 1, 2023

Related Issues

Fixes #11122

Proposed Changes

SectorReceive API mistakenly expects RandomnessFromTicket as a result of WaitSeed. However, we should be using RandomnessFromBeacon instead. Hence, I have changed a call of StateGetRandomnessFromTickets with StateGetRandomnessFromBeacon.

Additional Info

Info about this issue discussed on Filecoin slack, #fil-lotus-dev, ID p1690821347448089

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@mtrisic mtrisic requested a review from a team as a code owner August 1, 2023 10:54
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, I can imagine figuring this out took a while.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sector import: SectorReceive checks for wrong randomness
2 participants