Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F3: testground build doesn't include required parameters #12188

Closed
rvagg opened this issue Jul 5, 2024 · 0 comments
Closed

F3: testground build doesn't include required parameters #12188

rvagg opened this issue Jul 5, 2024 · 0 comments
Assignees
@Kubuxu @adlrocha

Comments

@rvagg
Copy link
Member

rvagg commented Jul 5, 2024

See https://github.com/filecoin-project/lotus/actions/runs/9799428990/job/27059662297#step:8:2368

Reproduce with:

$ go build -tags testground -o /dev/null ./cmd/lotus
# github.com/filecoin-project/lotus/build
build/params_shared_funcs.go:57:9: undefined: f3Enabled

build/params_testground.go needs the F3 constants that the other builds get: f3Enabled, ManifestServerID, F3BootstrapEpoch, or at least f3Enabled I suppose.
@LesnyRumcajs LesnyRumcajs mentioned this issue Jul 5, 2024
Closed
masih added a commit that referenced this issue Jul 5, 2024
@masih
Fix F3 build parameters for testground target
281e838 
Fix renamed `f3Enabled` flag and while at it, add place holder for
manifest server ID.

Fixes #12188
@masih masih mentioned this issue Jul 5, 2024
Merged
8 tasks
@masih masih closed this as completed in fbbfa1a Jul 5, 2024
rjan90 pushed a commit that referenced this issue Jul 5, 2024
@masih @rjan90
Fix F3 build parameters for testground target
71049e2 
Fix renamed `f3Enabled` flag and while at it, add place holder for
manifest server ID.

Fixes #12188
rjan90 added a commit that referenced this issue Jul 5, 2024
@rjan90 @masih
build: release: v1.28.0-rc4 (#12190)
ff0e889 
* Fix F3 build parameters for `testground` target

Fix renamed `f3Enabled` flag and while at it, add place holder for
manifest server ID.

Fixes #12188

* Update changelog and version

Update changelog and version

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>
rjan90 added a commit that referenced this issue Jul 11, 2024
@rjan90 @masih
build: release: v1.28.0-rc4 (#12190)
0b0f2dc 
* Fix F3 build parameters for `testground` target

Fix renamed `f3Enabled` flag and while at it, add place holder for
manifest server ID.

Fixes #12188

* Update changelog and version

Update changelog and version

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>
rjan90 added a commit that referenced this issue Jul 12, 2024
@rjan90 @jennijuju
@aarshkshah1992 @masih
chore: merge release/v1.28.0 / v1.28.0-rc4 back to master (#12211)
105b456 
* update genesis network version for dev testnets

* update version string

* changelog

* finish changelog

* final changes

* update CL

* Apply suggestions from code review

Co-authored-by: Phi-rjan <orjan.roren@gmail.com>

* fix typos

* Apply suggestions from code review

Co-authored-by: Masih H. Derkani <m@derkani.org>

* only soft laungh

* soft launch

* build: release: v1.28.0-rc2 (#12179)

* build: release: v1.28.0-rc3 (#12186)

* v1.28.0-rc3

* Update CHANGELOG.md

Co-authored-by: Phi-rjan <orjan.roren@gmail.com>

* Update CHANGELOG.md

---------

Co-authored-by: Phi-rjan <orjan.roren@gmail.com>

* build: release: v1.28.0-rc4 (#12190)

* Fix F3 build parameters for `testground` target

Fix renamed `f3Enabled` flag and while at it, add place holder for
manifest server ID.

Fixes #12188

* Update changelog and version

Update changelog and version

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>

* Update version master

Update version master

---------

Co-authored-by: Jennifer Wang <jiayingw703@gmail.com>
Co-authored-by: aarshkshah1992 <aarshkshah1992@gmail.com>
Co-authored-by: Masih H. Derkani <m@derkani.org>
Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kubuxu Kubuxu

@adlrocha adlrocha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rvagg @Kubuxu @adlrocha