Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: f3: Fix F3 build parameters for testground target #12189

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

masih
Copy link
Member

@masih masih commented Jul 5, 2024

Related Issues

#12188

Proposed Changes

Fix renamed f3Enabled flag and while at it, add place holder for manifest server ID.

Additional Info

None.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Fix renamed `f3Enabled` flag and while at it, add place holder for
manifest server ID.

Fixes #12188
@masih masih requested review from Kubuxu and rvagg July 5, 2024 07:41
@masih masih merged commit fbbfa1a into master Jul 5, 2024
78 checks passed
@masih masih deleted the masih/fix-f3-testground-params branch July 5, 2024 07:48
@rjan90 rjan90 mentioned this pull request Jul 5, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants