Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API breaking change in network version numbering #6898

Closed
7 tasks done
Stebalien opened this issue Jul 28, 2021 · 0 comments · Fixed by #7007
Closed
7 tasks done

API breaking change in network version numbering #6898

Stebalien opened this issue Jul 28, 2021 · 0 comments · Fixed by #7007
Labels
area/api impact/api-breakage Impact: API Breakage kind/bug Kind: Bug P1 P1: Must be resolved
Milestone

Comments

@Stebalien
Copy link
Member

Stebalien commented Jul 28, 2021

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

lotus JSON-RPC API

Lotus Version

master

Describe the Bug

See: filecoin-project/go-state-types#30 (comment)

Changing the network version numbers (1 -> 100, etc.) is technically API breaking. We either need to bump the API version, or handle this somehow.

Now, we can handle one half pretty easily: if we're a "lite" node, we can "upgrade" version numbers by multiplying all version numbers less than 100 by 100.

The tricky part is that anything consuming the API will still be broken. Unfortunately, there likely is no good way to fix that without bumping the API version.

Logging Information

None.

Repo Steps

No response

@Stebalien Stebalien added this to the 1.11.1 milestone Jul 28, 2021
@jennijuju jennijuju added area/api impact/api-breakage Impact: API Breakage P1 P1: Must be resolved and removed need/triage labels Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api impact/api-breakage Impact: API Breakage kind/bug Kind: Bug P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants