Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont panic if input is bad #7007

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Dont panic if input is bad #7007

merged 3 commits into from
Aug 10, 2021

Conversation

whyrusleeping
Copy link
Member

Will mostly fix #6898 when it compiles. (at least, will prevent things from panicking and give the user more of an idea of what is going wrong).

@whyrusleeping whyrusleeping requested a review from a team as a code owner August 9, 2021 10:18
@jennijuju jennijuju added P3 P3: Might get resolved tribute labels Aug 9, 2021
@jennijuju jennijuju marked this pull request as draft August 9, 2021 18:49
@ZenGround0 ZenGround0 marked this pull request as ready for review August 10, 2021 17:12
@ZenGround0
Copy link
Contributor

Need to fix actors policy gen.

@ZenGround0 ZenGround0 changed the title WIP: dont panic if input is bad Dont panic if input is bad Aug 10, 2021
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit you can ignore.

@Stebalien Stebalien merged commit 65e3540 into master Aug 10, 2021
@Stebalien Stebalien deleted the fix/panic-less branch August 10, 2021 23:22
@jennijuju jennijuju removed the tribute label Aug 13, 2021
@jennijuju jennijuju mentioned this pull request Aug 13, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 P3: Might get resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API breaking change in network version numbering
4 participants