Hyperspace nv20: upgrade and migration. #10243

raulk · 2023-02-12T14:26:52Z

This PR adds support for Hyperspace's network version 20.

Depedencies-wise:

Upgrades FFI to its Hyperspace branch: https://github.com/filecoin-project/filecoin-ffi/tree/ntwk/hyperspace
- Integrates the following ref-fvm branch: https://github.com/filecoin-project/ref-fvm/tree/release/hyperspace-nv19
Adds actor bundles for nv20: https://github.com/filecoin-project/builtin-actors/releases/tag/dev%2F20230210-pre-rc.8
Upgrades to this branch of go-state-types: Hyperspace nv20 / av12 go-state-types#159

Functionality-wise:

Re-adds support for the legacy event type (containing no codec field).
Adds code to adapt old EVM events to new EVM events, so that the rest of the system only needs to know about the latter.
Maintains consensus on events in nv19 and below.
Migrates the event index by upgrading old events to new events, backfilling the codec, removing the CBOR framing from values, rewriting topic keys, and padding topic values to 32 bytes.
Makes all parts of the system use ChainGetEvents to load events. This makes it easy to centralise the "upgrade" logic when reading old events from the store.
Retains compatibility with Delegated signatures carrying MethodSend in network versions below 20.
On network versions below 20, still generates Delegated messages with MethodSend if no parameters are set.

Test plan:

We probably want the non-Hyperspace specific parts of this commit on release/v1.20.0, as it cleans up event handling more generally.

Otherwise we may, e.g., try to estimate gas on a message to an f4 address before the nv18 migration. I'm _not_ checking the "prior messages" here as this is just a sanity check.

arajasek

Broadly looks good to me -- didn't look too closely at the events changes, but everything else looks like this will be a successful upgrade :)

chain/consensus/filcns/upgrades.go

chain/messagepool/messagepool.go

chain/vm/fvm.go

itests/migration_nv20_test.go

Stebalien · 2023-02-13T19:49:51Z

node/impl/full/chain.go

+ return nil, nil
+ }
+
+ // Hyperspace nv20: we peek into the events array to figure out if these


This is highlighting an issue with this API. I'm not sure what the right fix is, but this is going to be painful going forward if/when we change the events structure.

fixes filecoin-project/ref-fvm#1662

Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com> Co-authored-by: Raúl Kripalani <raul@protocol.ai>

…ge-validity fix: stmgr: check message validity before invoking vm

This: - Improves error handling when the FFI is passed invalid messages. - Updates the FVM.

chore: ffi: update the FFI

This reverts commit 2bbd1fb.

fix: stmgr: copy the message before modifying it

Base automatically changed from raulk/hyperspace-nv20-backwards-compatibility to raulk/hyperspace-nv20-staging February 12, 2023 21:04

raulk force-pushed the raulk/hyperspace-nv20-staging branch 2 times, most recently from 1f175fe to bd63953 Compare February 12, 2023 21:52

raulk added 23 commits February 12, 2023 21:53

fvm: upgrade ffi.

9f7e1be

actors: add actors v12 bundle.

2addc9f

events: re-add a legacy event for backwards compatibility.

2302958

events: adapt events when under nv20.

e8cef64

delegated signature: allow it to carry MethodSend before nv20.

493dabe

go mod tidy and format.

766eb76

events: make everything use ChainGetEvents; adapt legacy events.

ed1a775

We probably want the non-Hyperspace specific parts of this commit on release/v1.20.0, as it cleans up event handling more generally.

events: get the event translation right.

065e70f

tests: update test network version to 20.

988961f

gen actors v12; keep migration unimplemented.

3b5a9b7

fix test failure.

fa9cb2a

fix missing actors v12 in ActorRegistry.

1786a8a

actors v12 migration + nv20 upgrade epochs.

feaf397

nv20: migrate event index.

89d0c1c

fix imports.

9dfd605

event index: set the right version on creation.

5aeab8a

update v12 bundle.

098cd8a

add a migration test.

78c990d

fix signature backwards compatibility.

02eb26e

do not register older actor versions.

449b933

fix: update ffi to pass chain id.

96a7da5

fix: legacy event.

021750a

upgrade to go-state-types@237a27b.

e8fd766

raulk force-pushed the raulk/hyperspace-nv20-migration branch from 00b191e to e8fd766 Compare February 12, 2023 21:54

raulk mentioned this pull request Feb 12, 2023

Hyperspace nv20 staging branch #10240

Merged

make gen.

f189abf

raulk force-pushed the raulk/hyperspace-nv20-migration branch from e43a1cc to f189abf Compare February 12, 2023 21:59

fix: stmgr: check message validity before invoking vm

2bbd1fb

Otherwise we may, e.g., try to estimate gas on a message to an f4 address before the nv18 migration. I'm _not_ checking the "prior messages" here as this is just a sanity check.

arajasek approved these changes Feb 13, 2023

View reviewed changes

chain/consensus/filcns/upgrades.go Outdated Show resolved Hide resolved

fix: ethaccount: reject empty initcode prior to h-nv20

c49d98a

Stebalien reviewed Feb 13, 2023

View reviewed changes

raulk and others added 7 commits February 13, 2023 22:22

override flags when adapting events.

49aae69

remove stale comments.

11eace5

simplify DecodeEvents.

0c2e64b

fix: eth: rename yParity to v in transaction return values (#10264)

a16c540

fixes filecoin-project/ref-fvm#1662

Eth JSON-RPC: populate reward in eth_feeHistory (#10245)

0d92c74

Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com> Co-authored-by: Raúl Kripalani <raul@protocol.ai>

Merge branch 'release/v1.20.0' into raulk/hyperspace-nv20-migration

1e8746c

update ffi@fead3c628794a332ebc2ef0a153885bfab87a901.

93ece33

Stebalien approved these changes Feb 14, 2023

View reviewed changes

raulk and others added 14 commits February 14, 2023 01:34

update v12 actor bundle to hyperspace/v10.0.0-rc.2.

32e9201

itest for block.difficulty (#10263)

9f2f915

Merge pull request #10259 from filecoin-project/steb/call-check-messa…

3c4a839

…ge-validity fix: stmgr: check message validity before invoking vm

chore: ffi: update the FFI

2ed92c2

This: - Improves error handling when the FFI is passed invalid messages. - Updates the FVM.

fix: itest: EthFeeHistory flake (#10265)

abeb4fa

Merge pull request #10266 from filecoin-project/steb/update-ffi

b1e1d2d

chore: ffi: update the FFI

Merge branch 'release/v1.20.0' into raulk/hyperspace-nv20-migration

a46e57e

fix: make eth_sendRawTransaction emit correct pre-nv20 messages.

d3a2a40

Revert "fix: stmgr: check message validity before invoking vm" (#10270)

11ac325

This reverts commit 2bbd1fb.

Merge branch 'release/v1.20.0' into raulk/hyperspace-nv20-migration

be452b4

Merge pull request #10258 from filecoin-project/steb/fix-msg-modify

86b4aee

fix: stmgr: copy the message before modifying it

feat: ethrpc: Support newPendingTransactions in eth_subscribe (#10269)

7150243

params 2k: give more time between nv19 and nv20 for transition tests.

b8d64a1

Merge branch 'release/v1.20.0' into raulk/hyperspace-nv20-migration

fe85674

raulk merged commit b115c18 into raulk/hyperspace-nv20-staging Feb 14, 2023

raulk deleted the raulk/hyperspace-nv20-migration branch February 14, 2023 16:35

maciejwitowski mentioned this pull request Feb 15, 2023

Add migration for Hyperspace upgrade filecoin-project/ref-fvm#1441

Closed

Fatman13 mentioned this pull request Feb 20, 2023

[venus] merge nv19 consensus / NV19 代码合并 filecoin-project/venus#5678

Closed

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hyperspace nv20: upgrade and migration. #10243

Hyperspace nv20: upgrade and migration. #10243

raulk commented Feb 12, 2023 •

edited

Loading

arajasek left a comment

Stebalien Feb 13, 2023

Hyperspace nv20: upgrade and migration. #10243

Hyperspace nv20: upgrade and migration. #10243

Conversation

raulk commented Feb 12, 2023 • edited Loading

arajasek left a comment

Choose a reason for hiding this comment

Stebalien Feb 13, 2023

Choose a reason for hiding this comment

raulk commented Feb 12, 2023 •

edited

Loading