Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: events: Lotus API to consume events (smart contract + built-in Actor events) #11540
feat: events: Lotus API to consume events (smart contract + built-in Actor events) #11540
Changes from 60 commits
8db6e73
c9f1325
271a011
538039f
956ac8a
943c223
2d75cc5
685934a
91b0032
e0a8fe3
e570693
3d30ded
9dd9458
4b1445e
93fd408
bf5132e
d32b8be
efb4a09
cf8fed9
0e49673
1e09e1e
4ab92ca
986f240
88e90aa
7f684ec
f2a4891
4a5c241
9dca434
68c1e56
89fabbb
47477c0
96353e6
de38e77
c912f3b
6faeaa7
d75d7c7
17f6f4c
fac1d11
d21802f
cfd57cb
f7a36f6
9f671af
55ed4cd
4a59c01
5a0c2bc
0bf15fa
874b8ca
f33e154
c67ed4b
4d72fda
3ad99bf
462e061
a5fb594
db0d736
a9c8959
7b6d763
b8f7520
b02338a
a4f89a7
147c47e
2a219e2
ff17d7f
b54d111
3f2c3a3
cc04504
a694690
f9c891b
b5fba58
4cfd4f0
8e71abf
3faac88
e500393
1744741
1bd7257
1880835
55784cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this is a great API; It feels really clunky to have to specify the codec here, which is encouraged by the clunky nature of the events themselves of course (!).
We do have the option of leaving the Codec off and just keeping it
map[string][][]byte
and matching on that, the bytes are going to remain the same, identical to theValue
they provide here. It will lack the precision of saying "this value, which is this codec", but that's not too much different from just "this value".It's not like we're doing anything fancy with the
Codec
here of course—e.g. decoding theirValue
and re-encoding it to the codec specified by the event, theValue
is the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg
Yeah this is true. I think just a nice way for clients to ensure they're using the right codec as we use different ones for smart contract vs built-in Actor events so they're not left wondering why their filter isn't matching anything. I think best to keep it for now to make it explicit. We can remove this later once our experimental API gets some feedback.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.