Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: markets 0.6.0 with non-blocking retrieval #3541

Closed
wants to merge 3 commits into from

Conversation

hannahhoward
Copy link
Contributor

Goals

Utilize new payment channel functionality to allow retrievals to proceed w/o waiting for chain operations more frequently, as long as there are funds in channel for vouchers

Implementation

  • Adjust the node adapter to the new node functions, which also align more closely to PayAPI funcs
    • note one part is held up on one more piece of functionality from @dirkmc
  • Remove use of direct references to PayChMgr in retrieval client adapter wherever possible (fewer assumptions of running in same process the better)
  • Add the ability when adding funds to the payment channel to restart any retrieval deals that have stalled on insufficient funds. While this is unlikely to happen as long as retrieval deals are the only consumers of payment channels, once we add other consumers, they might use the retrieval funds and cause deals to run out of money. This allows us to add more money to a payment channel manually as a way to unstick these deals

This was referenced Sep 7, 2020
@hannahhoward hannahhoward force-pushed the feat/upgrade-markets-0.6.0 branch from 0fce061 to c155672 Compare September 7, 2020 12:34
@hannahhoward hannahhoward mentioned this pull request Sep 7, 2020
@arajasek
Copy link
Contributor

arajasek commented Sep 7, 2020

Pulled into #3603

@arajasek arajasek closed this Sep 7, 2020
@Kubuxu Kubuxu deleted the feat/upgrade-markets-0.6.0 branch November 25, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants