Fixes Issue#674: Refactored var declarations to const or let declarations to address i…

[ndngo]

…issue#674

Added the 'use strict' declaration at the top and refactored var variable declarations to use const or let.

[codecov-io]

Codecov Report

Merging #676 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...8d8e54d. Read the comment docs.

[trowacat]

Good initiative ndngo, I am wondering if it would be best to make more use of const in the file however. I notice a lot of use of let when the function is not actually changing any values. It might be best in such cases to use const instead.

[jatinkumarg]

I think 'let' will be fine as there are multiple declarations of variables with the same name. By using let as the data type for "fs" and "fsPromise" will make them block-scoped. Check out this link.

[humphd]

Agree that const is best when the variable won't change values (e.g., fs will always be the same thing within each test scope). Save let for cases where it will change.

[ndngo]

That makes sense. I have changed variables that don't change values to be declared with const.

[jatinkumarg]

Thanks for the clarification, I have also changed the code to use const in the fs.readdir.spec.js file.

[humphd]

Looks great.