Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue#674: Refactored var declarations to const or let declarations to address i… #676

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Fixes Issue#674: Refactored var declarations to const or let declarations to address i… #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f1fe8b
Refactored var declarations to const or let declarations to address i…
ndngo Jan 25, 2019
8d8e54d
refactored let to const when variable does not change values
ndngo Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions tests/spec/fs.chmod.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
var util = require('../lib/test-utils.js');
var expect = require('chai').expect;
'use strict';

const util = require('../lib/test-utils.js');
const expect = require('chai').expect;

describe('fs.chmod, fs.fchmod', function() {
beforeEach(util.setup);
afterEach(util.cleanup);

it('should be functions', function() {
var fs = util.fs();
const fs = util.fs();
expect(typeof fs.chmod).to.equal('function');
expect(typeof fs.fchmod).to.equal('function');
});

it('should automatically set mode=755 for a directory', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.mkdir('/dir', function(err) {
if(err) throw err;
Expand All @@ -26,7 +28,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should automatically set mode=644 for a file', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.open('/file', 'w', function(err, fd) {
if(err) throw err;
Expand All @@ -40,7 +42,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should be an error when the path is invalid', function(done){
var fs = util.fs();
const fs = util.fs();
fs.chmod('/invalid_path', 0o444, function(err){
expect(err).to.exist;
expect(err.code).to.equal('ENOENT');
Expand All @@ -49,7 +51,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should error if mode value is a non-numeric string', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.mkdir('/dir', function(err) {
if(err) throw err;
Expand All @@ -63,7 +65,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should error if mode value is null', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.mkdir('/dir', function(err) {
if(err) throw err;
Expand All @@ -77,7 +79,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should error if mode value is non-integer number', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.mkdir('/dir', function(err) {
if(err) throw err;
Expand All @@ -91,7 +93,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should error if mode value is non-integer number', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.mkdir('/dir', function(err) {
if(err) throw err;
Expand All @@ -105,7 +107,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should allow octal strings for mode value', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.mkdir('/dir', function(err) {
if(err) throw err;
Expand All @@ -124,7 +126,7 @@ describe('fs.chmod, fs.fchmod', function() {
});

it('should allow for updating mode of a given file', function(done) {
var fs = util.fs();
const fs = util.fs();

fs.open('/file', 'w', function(err, fd) {
if(err) throw err;
Expand Down Expand Up @@ -161,12 +163,12 @@ describe('fsPromise.chmod', function() {
afterEach(util.setup);

it('should be a function', function() {
var fsPromise = util.fs().promises;
const fsPromise = util.fs().promises;
expect(typeof fsPromise.chmod).to.equal('function');
});

it('should allow for updating mode of a given file', function() {
var fsPromise = util.fs().promises;
const fsPromise = util.fs().promises;

return fsPromise.open('/file', 'w')
.then(() => fsPromise.chmod('/file', 0o444))
Expand Down