Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdc3 for web impl test policy #1480

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

robmoffat
Copy link
Member

@robmoffat robmoffat commented Dec 19, 2024

Describe your change

Adds testing policy for FDC3-On-The-Web quality control for FDC3 2.2

Related Issue

resolves #810
resolves #832

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • CHANGELOG: Is a CHANGELOG.md entry included?

@robmoffat robmoffat requested a review from a team as a code owner December 19, 2024 13:02
@robmoffat robmoffat changed the base branch from main to fdc3-for-web-impl December 19, 2024 13:03
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 48b93e4
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/676419830d55570008643668
😎 Deploy Preview https://deploy-preview-1480--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

424 passed

Copy link

github-actions bot commented Dec 19, 2024

Coverage Report

Commit: 67356c1
Base: fdc3-for-web-impl@fb996b1

Type Base This PR
Total Statements Coverage  97.32%  95.92% (-1.4%)
Total Branches Coverage  86.09%  81.72% (-4.37%)
Total Functions Coverage  98.07%  97.36% (-0.71%)
Total Lines Coverage  97.33%  95.99% (-1.34%)
Details (changed files)
FileStatementsBranchesFunctionsLines
Details (all files)
FileStatementsBranchesFunctionsLines
packages/fdc3-agent-proxy/src/BasicDesktopAgent.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/index.ts 100% 100% 71.42% 100%
packages/fdc3-agent-proxy/src/apps/DefaultAppSupport.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/channels/DefaultChannel.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/channels/DefaultChannelSupport.ts 94.64% 75% 93.33% 94.33%
packages/fdc3-agent-proxy/src/channels/DefaultPrivateChannel.ts 97.05% 75% 100% 97.05%
packages/fdc3-agent-proxy/src/handshake/DefaultHandshakeSupport.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/intents/DefaultIntentResolution.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/intents/DefaultIntentSupport.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/listeners/AbstractListener.ts 94.44% 83.33% 100% 94.44%
packages/fdc3-agent-proxy/src/listeners/DefaultContextListener.ts 100% 92.3% 100% 100%
packages/fdc3-agent-proxy/src/listeners/DefaultIntentListener.ts 100% 80% 100% 100%
packages/fdc3-agent-proxy/src/listeners/EventListener.ts 90% 50% 80% 90%
packages/fdc3-agent-proxy/src/listeners/HeartbeatListener.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/listeners/PrivateChannelEventListener.ts 100% 100% 100% 100%
packages/fdc3-agent-proxy/src/messaging/AbstractMessaging.ts 92.3% 78.94% 93.75% 92.15%
packages/fdc3-get-agent/src/Fdc3Version.ts 100% 100% 100% 100%
packages/fdc3-get-agent/src/index.ts 100% 100% 100% 100%
packages/fdc3-get-agent/src/messaging/AbstractWebMessaging.ts 100% 66.66% 100% 100%
packages/fdc3-get-agent/src/messaging/MessagePortMessaging.ts 95% 75% 100% 95%
packages/fdc3-get-agent/src/messaging/message-port.ts 96.29% 92.85% 100% 96.29%
packages/fdc3-get-agent/src/strategies/ElectronEventLoader.ts 100% 100% 100% 100%
packages/fdc3-get-agent/src/strategies/PostMessageLoader.ts 98.27% 70% 100% 98.24%
packages/fdc3-get-agent/src/strategies/TimeoutLoader.ts 100% 85.71% 100% 100%
packages/fdc3-get-agent/src/strategies/getAgent.ts 92.68% 76.92% 91.66% 92.1%
packages/fdc3-get-agent/src/ui/AbstractUIComponent.ts 100% 83.33% 100% 100%
packages/fdc3-get-agent/src/ui/DefaultDesktopAgentChannelSelector.ts 100% 66.66% 100% 100%
packages/fdc3-get-agent/src/ui/DefaultDesktopAgentIntentResolver.ts 100% 75% 100% 100%
packages/fdc3-get-agent/src/ui/NullChannelSelector.ts 100% 100% 100% 100%
packages/fdc3-get-agent/src/ui/NullIntentResolver.ts 100% 100% 66.66% 100%
packages/fdc3-standard/src/index.ts 100% 100% 0% 100%
packages/fdc3-standard/src/api/Errors.ts 100% 100% 100% 100%
packages/fdc3-standard/src/api/GetAgent.ts 100% 100% 100% 100%
packages/fdc3-standard/src/api/Methods.ts 94.04% 84.05% 96.29% 95%
packages/fdc3-standard/src/api/RecommendedChannels.ts 100% 100% 100% 100%
packages/fdc3-standard/src/context/ContextType.ts 100% 100% 100% 100%
packages/fdc3-standard/src/intents/Intents.ts 100% 100% 100% 100%
packages/fdc3-standard/src/internal/contextConfiguration.ts 100% 100% 100% 100%
packages/fdc3-standard/src/internal/intentConfiguration.ts 100% 100% 100% 100%
packages/fdc3-standard/src/internal/typeHelpers.ts 100% 100% 100% 100%
toolbox/fdc3-for-web/fdc3-web-impl/src/BasicFDC3Server.ts 100% 100% 100% 100%
toolbox/fdc3-for-web/fdc3-web-impl/src/ServerContext.ts 100% 100% 100% 100%
toolbox/fdc3-for-web/fdc3-web-impl/src/directory/BasicDirectory.ts 96.77% 84.21% 100% 96.42%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/BroadcastHandler.ts 95.33% 84.26% 100% 95.1%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/HeartbeatHandler.ts 82.35% 64.86% 92.85% 84%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/IntentHandler.ts 90.81% 72.6% 98.18% 90.24%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/OpenHandler.ts 96.77% 79.48% 100% 96.77%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/support.ts 100% 100% 100% 100%

This was linked to issues Dec 19, 2024
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on.

I don't quite understand the latter section of the policy, which appears to conflict with the first part (which breaks out sub-module policies). See the comment - I may be readingit wrong (in which case it could be clarified).

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@kriswest kriswest self-requested a review January 14, 2025 16:16
@robmoffat robmoffat requested review from a team and removed request for kriswest January 14, 2025 16:16
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robmoffat
Copy link
Member Author

Can an FDC3 maintainer take a look at this new testing policy please?

Co-authored-by: Kris West <kris.west@interop.io>
Copy link

424 passed

2 similar comments
Copy link

424 passed

Copy link

424 passed

Copy link
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kriswest kriswest merged commit 6ccd641 into fdc3-for-web-impl Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test Policy Configure OpenSSF Badging For FDC3
4 participants