Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdc3 for web impl test policy #1480

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Fdc3 for web impl test policy #1480

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e0774b
Added test policy in contributing section
robmoffat Dec 19, 2024
48b93e4
added changelog
robmoffat Dec 19, 2024
8162392
Update CONTRIBUTING.md
robmoffat Jan 14, 2025
ee7f931
Update CONTRIBUTING.md
robmoffat Jan 14, 2025
67356c1
Update CONTRIBUTING.md
robmoffat Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Added utility functions `isStandardContextType(contextType: string)`, `isStandardIntent(intent: string)`,`getPossibleContextsForIntent(intent: StandardIntent)`. ([#1139](https://github.com/finos/FDC3/pull/1139))
* Added support for event listening outside of intent or context listnener. Added new function `addEventListener`, type `EventHandler`, enum `FDC3EventType` and interfaces `FDC3Event` and `FDC3ChannelChangedEvent`. ([#1207](https://github.com/finos/FDC3/pull/1207))
* Added new `CreateOrUpdateProfile` intent. ([#1359](https://github.com/finos/FDC3/pull/1359))
* Added separate `fdc3-commonjs` module for compatibility with older projects that use CommonJS. ([#1452](https://github.com/finos/FDC3/pull/1452))
* Added separate `fdc3-commonjs` module for compatibility with older projects that use CommonJS. ([#1452](https://github.com/finos/FDC3/pull/1452))
* Added testing policy to [Contributing](CONTRIBUTING) page to address ([810](https://github.com/finos/FDC3/issues/810))

### Changed

Expand Down
25 changes: 25 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,31 @@ The Working Group uses pull requests to track changes. To submit a change to the

To contribute a patch for a New Intent, see the [Submit New Intent](docs/guides/submit-new-intent) guide.

**3.6. Test Policy**

- The FDC3 project takes very seriously code quality, especially with respect to production-grade sub-modules. This includes:

|Module | Test Policy |
|---|---|
|`packages/fdc3-agent-proxy` | Contributions must improve or maintain coverage at the current levels |
|`packages/fdc3-get-agent` |Contributions must improve or maintain coverage at the current levels
|`packages/fdc3-commonjs` | Code should not be added here |
|`packages/fdc3-context` | Must contain only JSON Schemas |
|`packages/fdc3-schema` | Must contain only JSON Schemas |
|`packages/fdc3-context` | Must contain only JSON Schemas |
|`packages/fdc3-standard` | Contributions must improve or maintain coverage at the current levels |
|`toolbox/fdc3-for-web/fdc3-web-impl` | Contributions must improve or maintain coverage at the current levels |
robmoffat marked this conversation as resolved.
Show resolved Hide resolved

Please note that the FDC3 project uses the following test policy:

* All code must be tested (coverage is reported in the PR comments)
robmoffat marked this conversation as resolved.
Show resolved Hide resolved
robmoffat marked this conversation as resolved.
Show resolved Hide resolved
* All tests must pass. (checked automatically by the PR comments)
* All new code must be covered by tests.
robmoffat marked this conversation as resolved.
Show resolved Hide resolved
* All tests must be meaningful.
* All tests must be kept up-to-date.
* All tests must be run locally before submitting a PR.
* Finally, the `toolbox/fdc3-for-web/demo` project is expected to pass the FDC3 conformance framework prior to new FDC3 releases (not currently automated).

## 4. Pull Request Workflow.

The next section contains more information on the workflow followed for Pull Requests.
Expand Down
Loading