Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and publish context schema files #170

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Rename and publish context schema files #170

merged 4 commits into from
Feb 19, 2020

Conversation

rikoe
Copy link
Contributor

@rikoe rikoe commented Feb 9, 2020

  • Change schema file extensions
  • Change schema $id property to use correct target URI (without version, but "next" instead)
  • Change "enum" for "type" to be "const", which is the more correct JSON schema usage
  • Some changes to some types to bring in line with FinObj types
  • Copy to website/static/schemas/next folder as part of build
  • Update links in context schema spec to point to published schemas

@rikoe rikoe requested a review from nkolba February 9, 2020 20:13
@rikoe rikoe added the context-data FDC3 Context Data Working Group label Feb 9, 2020
@rikoe rikoe added this to the 1.1 milestone Feb 9, 2020
@rikoe rikoe requested a review from donbasuno February 9, 2020 20:17
rikoe added 4 commits February 13, 2020 14:43
@rikoe
finos#128 - rename schema files and delete old examples
0795fb0 
- Change schema file extensions
- Change schema $id property to use correct target URI (without version, but "next" instead)
- Change "enum" for "type" to be "const", which is the more correct JSON schema usage
- Some changes to some types to bring in line with FinObj types
@rikoe
finos#128 - copy schemas as static website files as part of build
ffef5a2 
- Copy to schemas/next folder with npm command
- Make part of website pre-publish script during build
- Update links in context schema spec to point to published schemas
@rikoe
Review comments
3baa9d1 
- remove FDS_ID from contact
- make holding mandatory on position
@rikoe
Small context tweaks
e422c08
@rikoe rikoe force-pushed the publish-schema-files branch from 17cec02 to e422c08 Compare February 13, 2020 16:30
@rikoe rikoe merged commit 47a597b into finos:master Feb 19, 2020
@rikoe rikoe deleted the publish-schema-files branch February 19, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolba nkolba nkolba approved these changes

@donbasuno donbasuno Awaiting requested review from donbasuno

Assignees
No one assigned
Labels
cla-present context-data FDC3 Context Data Working Group
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@rikoe @nkolba @donbasuno @finos-admin