Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR For Issue 243 Allow Specification of Channel MetaData during Channel Creation #244

Closed
wants to merge 4 commits into from
Closed

PR For Issue 243 Allow Specification of Channel MetaData during Channel Creation #244

wants to merge 4 commits into from

Conversation

sgd2z
Copy link
Contributor

@sgd2z sgd2z commented Sep 16, 2020

@sgd2z sgd2z mentioned this pull request Sep 16, 2020
Closed
rikoe
rikoe suggested changes Sep 16, 2020
View reviewed changes
src/api/DesktopAgent.ts Show resolved Hide resolved
src/api/DesktopAgent.ts Outdated Show resolved Hide resolved
@sgd2z sgd2z requested a review from rikoe September 16, 2020 17:14
@rikoe
Copy link
Contributor

rikoe commented Oct 22, 2020

@sgd2z I propose we close this for the time being, as we haven't reached consensus for this one and it isn't currently planned for 1.2 (if I am correct), and this particular approach was observed as somewhat ambiguous/confusing by the standards working group.

@sgd2z
Copy link
Contributor Author

sgd2z commented Oct 22, 2020

@sgd2z I propose we close this for the time being, as we haven't reached consensus for this one and it isn't currently planned for 1.2 (if I am correct), and this particular approach was observed as somewhat ambiguous/confusing by the standards working group.

I have a poll in the issue itself on which of two options to pick. I'll update the PR accordingly once a decision is made.

@nkolba
Copy link
Contributor

nkolba commented Oct 29, 2020

@sgd2z - I've commented on the related issue. We haven't gotten response on the poll. Should we close issue and PR for now and take up again when we have more supporting use cases in this area?

@rikoe rikoe added this to the 2.0 milestone Jan 26, 2021
@rikoe rikoe added the api FDC3 API Working Group label Jan 27, 2021
@kriswest
Copy link
Contributor

Closing as the associated issue was closed

@kriswest kriswest closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikoe rikoe Awaiting requested review from rikoe

Assignees
No one assigned
Labels
api FDC3 API Working Group cla-present
Projects
None yet
Milestone
2.0-candidates
Development

Successfully merging this pull request may close these issues.
4 participants
@sgd2z @rikoe @nkolba @kriswest