Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR For Issue 243 Allow Specification of Channel MetaData during Channel Creation #244

Closed
wants to merge 4 commits into from
Closed

PR For Issue 243 Allow Specification of Channel MetaData during Channel Creation #244

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9adeacc
Allow displayMetaData to be specified at Channel creation time
Jun 3, 2020
fbcc95b
comment
Jun 3, 2020
88413ca
Merge remote-tracking branch 'origin/master' into channel-creation
Sep 16, 2020
bb78817
update spelling
Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/api/DesktopAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,11 @@ interface DesktopAgent {
* It is up to applications to manage how to share knowledge of these custom channels across windows and to manage
* channel ownership and lifecycle.
*
* If `displayMetaData` is specified, the channel is visually selectable by the user. If the channel already exists, displayMetaData is ignored.
*
sgd2z marked this conversation as resolved.
Show resolved Hide resolved
* `Error` with a string from the `ChannelError` enumeration.
*/
getOrCreateChannel(channelId: string): Promise<Channel>;
getOrCreateChannel(channelId: string, displayMetaData?: DisplayMetaData): Promise<Channel>;
sgd2z marked this conversation as resolved.
Show resolved Hide resolved

/**
* Returns the `Channel` object for the current channel membership.
Expand Down