Adding a toolbox directory and the FDC3 Explained app #367
Conversation
Updating fork
Better detection of FDC3 and removing hard-coded FDC3 service name
test looks good
There was a problem hiding this comment.
@donbasuno @rikoe I'd like to see this PR move forward and get merged - however I think it needs a few changes:
- Ensure all files encapsulated in a folder under the 'toolbox' folder to ensure we can use it for other tools, i.e. toolbox/fdc3-explained
- Rename the root page from toolbox/fdc3_explained.html to toolbox/fdc3-explained/index.html (and correct relative URLs in that file).
- Also move toolbox/fdc3_explained_logo.svg -> toolbox/fdc3-explained/fdc3_explained_logo.svg
- Remove duplicate files:
- Is toolbox/legacy.html still relevant? if superceded by toolbox/fdc3-explained/1.0/index.html please remove it.
- website/static/demos/fdc3_explained.html appears to be another duplicate
- Ensure that the 1.2 version uses the the
fdc3.getInfo()function to get provider details - meaning vendor specific code can be removed - Remove vendor specific manifest files in toolbox/openfin directory
- these include URLs that point to https://donbasuno.github.io, rather than final location in the FDC3 repository
- A sample appD entry would be a more appropriate way of demonstrating how to include the app in your desktop agent.
- Add a Readme file to the toolbox/fdc3-explained folder
Once these files are included in the repository, we can open a separate PR to host them as part of the website and to create an implementations page and link to them.
| function getPlatform() { | ||
|
|
||
| // TODO: add G42 to vendors | ||
| if (window.FSBL) { | ||
| window.FSBL.getFSBLInfo().then((info) => { | ||
| document.getElementById('providerDetails').innerHTML = "Finsemble Version:" + info.FSBLVersion; | ||
| }); | ||
| } else if (window.fin) { | ||
| fin.desktop.Application.getCurrent().getInfo((info) => { | ||
| document.getElementById('providerDetails').innerHTML = info.manifest.startup_app.name | ||
| }); | ||
| } else if (window.fdc3) { | ||
| document.getElementById('providerDetails').innerHTML = "FDC3 Desktop Agent Chrome Extension"; | ||
| } | ||
| else { | ||
| // no need to update the DOM there is already a default message just return | ||
| return | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
getPlatform should be updated to use fdc3.getInfo() to get platform metadata. Vendor specific code should be removed
| @@ -0,0 +1,192 @@ | |||
| <html> | |||
There was a problem hiding this comment.
This file appears to be a legacy copy of the FDC3Explained page - it should probably be removed.
|
Thanks for this list @kriswest - I've been meaning to my comments to this PR for a while. In addition to the tasks you mention, we will need to figure out how deployment is going to work, as it won't work as is. In the source repository, GitHub pages is used to just deploy what is in the toolbox folder as a website, but in this repository it works differently. We deploy the content of the website folder to GitHub pages via Docusaurus, so to get this deployed properly, we would either have to make the toolbox a subfolder of The other issues I would like to resolve are:
|
kriswest
added
enhancement
|
Closing in favour of #535 |
Let the tooling project live long and prosper!