165 Add FDC3 Explained to the toolbox folder #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikoe
requested review from
mattjamieson,
kriswest,
donbasuno and
ggeorgievx
Update toolbox/fdc3-explained/index.html Co-authored-by: Kris West <kris@cosaic.io>
Adding the legacy, pre 1.1 app
- Move from website/static folder to toolbox/fdc3-explained - Remove legacy.html - Rename logo svg file - Remove toolbox/demoapps - Split out JavaScript and CSS from v1.0 html file, and clean up - Remove dependency on versions.js file, just hard code to simplify code - Improve handling of switching between different versions with drop-down - Ensure that user informed no FDC3 version is detected when not running in a desktop agent - Fix handling of OpenFin detection - Use fdc3.getInfo for v1.2 - Add README.md
rikoe
force-pushed
the
fdc3-explained
branch
from
f4f3016 to
78560ea
Compare
donbasuno
approved these changes
Jan 4, 2022
…data, issues with join and leave channel buttons, formatting of contexts, separating get context action onto a button for clarity/consistency, adjusting styles
|
Awaiting a few tweaks that are on a PR into Riko's branch. Will merge when those have been merged into this PR. |
kriswest
changed the title
kriswest
added
toolbox
kriswest
requested changes
Mar 16, 2022
Fixing several issues in fdc3 explained
mistryvinay
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #165
I have recreated the FDC3 Explained pull request based on #367.
I have made the following changes:
I believe if I did the build correctly, the deployment to the toolbox folder on the website should now also work, alongside that of FDC3 Workbench.
@kriswest I believe this addresses all your issues: