Improve the raiseIntent documentation #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add missing information and examples to the docs entry for raiseIntent and TS docs for same - add missing information and examples to the docs entry for raiseIntentForCOntext and TS docs for same - move resolvers section in spec to co-locate with raiseIntent - remove comments about versioning intents from spec as no functionality for doing so is defined
kriswest
requested review from
mattjamieson,
rikoe,
donbasuno,
ggeorgievx and
a team
14 tasks
kriswest
commented
Sep 23, 2021
a resolver UI *should* be shown if multiple apps match the intent and context
mattjamieson
approved these changes
Sep 23, 2021
14 tasks
rikoe
suggested changes
Oct 7, 2021
kriswest
commented
Oct 7, 2021
kriswest
commented
Oct 7, 2021
kriswest
commented
Oct 7, 2021
|
@rikoe Let me know if the suggested changes deal with your concerns on Resolver UIs |
…han a resolver UI
rikoe
approved these changes
Oct 8, 2021
11 tasks
kriswest
added
the
channels feeds & transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #426
Changes: