Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

533 experimental features #549

Merged
merged 10 commits into from
May 6, 2022
Merged

533 experimental features #549

merged 10 commits into from
May 6, 2022

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Jan 17, 2022 •
edited
Loading

resolves #533
Adds a proposed experimental features policy to the fdc3-compliance page of the website

@kriswest kriswest changed the base branch from master to versions-deprecation-policy January 17, 2022 16:58
kriswest
kriswest commented Jan 17, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
kriswest
kriswest commented Jan 17, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
hughtroeger
hughtroeger reviewed Jan 19, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
kriswest
kriswest commented Jan 20, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
kriswest
kriswest commented Jan 20, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
kriswest
kriswest commented Jan 20, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
kriswest
kriswest commented Jan 20, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
kriswest
kriswest commented Jan 20, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
kriswest
kriswest commented Jan 20, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
@kriswest kriswest requested a review from hughtroeger January 20, 2022 11:57
hughtroeger
hughtroeger approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest mentioned this pull request Feb 17, 2022
Closed
@kriswest kriswest added the docs Documentation label Mar 16, 2022
@kriswest kriswest requested a review from mistryvinay March 16, 2022 13:08
mistryvinay
mistryvinay approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@kriswest kriswest mentioned this pull request Mar 24, 2022
Closed
13 tasks
@kriswest kriswest mentioned this pull request Apr 28, 2022
Closed
17 tasks
nkolba
nkolba requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@nkolba nkolba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, looks good to me. There's a type on item #6: 6. "The experimental designation maybe removed from a feature in a minor version release (as this will be considered an additive change)." 'maybe' should be 'may be'.

kriswest
kriswest commented Apr 29, 2022
View reviewed changes
docs/fdc3-compliance.md Outdated Show resolved Hide resolved
@kriswest
Copy link
Contributor Author

There's a type on item #6: 6.
Fixed, thanks @nkolba

@kriswest kriswest requested a review from nkolba April 29, 2022 09:44
@kriswest kriswest merged commit d205358 into versions-deprecation-policy May 6, 2022
@kriswest kriswest deleted the 533-experimental-features branch May 6, 2022 17:55
@kriswest kriswest mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughtroeger hughtroeger hughtroeger approved these changes

@mistryvinay mistryvinay mistryvinay approved these changes

@RexJaeschke RexJaeschke RexJaeschke approved these changes

@rikoe rikoe rikoe approved these changes

@mattjamieson mattjamieson Awaiting requested review from mattjamieson

@donbasuno donbasuno Awaiting requested review from donbasuno

@ggeorgievx ggeorgievx Awaiting requested review from ggeorgievx

@nkolba nkolba Awaiting requested review from nkolba

Assignees
No one assigned
Labels
docs Documentation formal specification project governance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Experimental Features
6 participants
@kriswest @nkolba @rikoe @RexJaeschke @mistryvinay @hughtroeger