Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

622 AppD lang and translations #670

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Apr 21, 2022

resolves #622
Adds lang and localizedVersions fields to the appD application record schema to support accessiblity (screenreaders need to know the primary language of the record content) and localisation (of both appD record's content and the applications themselves through alternative launch url/config/hostManifests)

Change agreed at meeting:

@kriswest kriswest requested review from hughtroeger and a team April 21, 2022 15:38
@kriswest kriswest added enhancement New feature or request app-directory labels Apr 21, 2022
@kriswest kriswest changed the title AppD lang and translations 622 AppD lang and translations Apr 21, 2022
@kriswest
Copy link
Contributor Author

@greyseer256 If you're in a reviewing mood, could you check #670 for me - its another one where the appD schema structure has to change (doesn't change the record structure much, but the YAML had to change) so I need to base other PRs off of it (or deal with a lot of conflicts)

Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good

CHANGELOG.md Outdated Show resolved Hide resolved
src/app-directory/specification/appd.yaml Outdated Show resolved Hide resolved
website/static/schemas/next/app-directory.yaml Outdated Show resolved Hide resolved
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
@kriswest kriswest merged commit 3976d29 into Appd-consolidated-update-branch Apr 22, 2022
@kriswest kriswest linked an issue May 16, 2022 that may be closed by this pull request
@kriswest kriswest deleted the AppD-lang-and-translations branch November 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-directory enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add language metadata to AppD for accessibility
2 participants