-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
369 AppD app categories #673
Conversation
Looks good to me - its a great list of categories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good
- allocations<br> | ||
- analytics<br> | ||
- charts<br> | ||
- chat<br> | ||
- communication<br> | ||
- compliance<br> | ||
- crm<br> | ||
- developer tools<br> | ||
- events<br> | ||
- execution management<br> | ||
- file sharing<br> | ||
- market data<br> | ||
- news<br> | ||
- networking<br> | ||
- order management<br> | ||
- office apps<br> | ||
- portfolio management<br> | ||
- presentation<br> | ||
- pricing<br> | ||
- productivity<br> | ||
- research<br> | ||
- risk<br> | ||
- screen sharing<br> | ||
- security<br> | ||
- spreadsheet<br> | ||
- trade cost analysis<br> | ||
- trading system<br> | ||
- training<br> | ||
- travel<br> | ||
- video<br> | ||
- visualisation<br> | ||
- weather<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a nitpick, but I'm just wondering if there's a better way to achieve newlines in yaml than
tags on every line. I'm not very familiar with yaml, but I did find this stackoverflow answer that seems relevant: https://stackoverflow.com/questions/3790454/how-do-i-break-a-string-in-yaml-over-multiple-lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can break lines in openapi descriptions written in yaml, but they won't render in the output... There are two options for rendering newlines and that's \n
or <br>
(although I should probably have written <br />
... Personally I don't have much of a preference.
In theory the github flavoured markdown should be working so this list should have rendered and not needed the line breaks... but it didn't.
switching from a >
to a |
block and putting a newline before the list caused it to render! much cleaner (in both code and rendered) now.
localizedVersions: { | ||
fr-FR: { | ||
title: FDC3 Table de travail, | ||
description: Outil de développement et de test pour les desktop agents et applications FDC3 | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supposed to be here right? Just wondering cause it seems like it might have belonged in #670
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep - these PRs keep changing the structure of the record so they are going into a consolidated branch (where the plan for the change was clear). We'll agree the less clear ones individually, merge them into the consolidated branch and then present the whole thing to the standards working group
resolves #369
Adds a categories field to the appD record (modelled on the web application manifest), along with a suggested list of categories.