Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

767 Add ViewChat Intent #796

Closed
wants to merge 2 commits into from
Closed

767 Add ViewChat Intent #796

wants to merge 2 commits into from

Conversation

symphony-jean-michael
Copy link
Contributor

@symphony-jean-michael symphony-jean-michael commented Aug 8, 2022 •
edited
Loading

This PR adds the 'ViewChat' intent.
See initial discussion #767

ℹ️ ChatRoom is used in this PR but defined in the other PR #794

@symphony-jean-michael symphony-jean-michael marked this pull request as ready for review August 8, 2022 13:16
@netlify
Copy link

netlify bot commented Aug 8, 2022 •
edited
Loading

✅ Deploy Preview for lambent-kulfi-cf51a7 canceled.

Name Link
🔨 Latest commit cbc349b
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/636baae5b6b80a0008cab36f

@mistryvinay mistryvinay added enhancement New feature or request intents Context Data & Intents Contexts & Intents Discussion Group labels Aug 17, 2022
@mistryvinay mistryvinay added this to the 2.1-candidates milestone Aug 24, 2022
@mistryvinay mistryvinay requested review from a team and kriswest August 24, 2022 10:21
@mistryvinay mistryvinay changed the title Add ViewChat Intent 767 Add ViewChat Intent Aug 24, 2022
mistryvinay
mistryvinay approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need another maintainer to also review.

@mistryvinay mistryvinay mentioned this pull request Aug 30, 2022
Closed
15 tasks
@mistryvinay mistryvinay linked an issue Oct 4, 2022 that may be closed by this pull request
'View Chat' intent #767
Closed
@mistryvinay mistryvinay mentioned this pull request Oct 4, 2022
Closed
14 tasks
@mistryvinay mistryvinay mentioned this pull request Oct 31, 2022
Closed
12 tasks
kriswest
kriswest requested changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a CHANGELOG.md entry in the unreleased section please

@symphony-jean-michael
Copy link
Contributor Author

Hi @kriswest
I've updated the changelog. Can you have a second look, please?
Thanks

@mistryvinay mistryvinay mentioned this pull request Nov 30, 2022
Closed
9 tasks
@symphony-jean-michael symphony-jean-michael mentioned this pull request Dec 8, 2022
Merged
@symphony-jean-michael
Copy link
Contributor Author

FYI, this PR is included in new one #882

@kriswest kriswest modified the milestones: 2.1-candidates, 2.1 Apr 27, 2023
@kriswest kriswest removed this from the 2.1 milestone Jul 25, 2023
@bingenito bingenito mentioned this pull request Nov 6, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriswest kriswest kriswest requested changes

@mistryvinay mistryvinay mistryvinay approved these changes

Assignees
No one assigned
Labels
Context Data & Intents Contexts & Intents Discussion Group enhancement New feature or request intents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'View Chat' intent
3 participants
@symphony-jean-michael @kriswest @mistryvinay