-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symphony PRs in FDC3 2.1 candidates #882
Symphony PRs in FDC3 2.1 candidates #882
Conversation
fix typo for roomId.
CHANGELOG.md
Outdated
* Added a `SendChatMessage` intent to be used when a user wants to send a message to an existing chat room. ([#794](https://github.com/finos/FDC3/pull/794)) | ||
* Added a context type representing a chat message (`fdc3.chat.message`). ([#794](https://github.com/finos/FDC3/pull/794)) | ||
* Added a context type representing a chat room (`fdc3.chat.room`). ([#794](https://github.com/finos/FDC3/pull/794)) | ||
* Added a chat `Message` type in order to describe messages with rich content and attachments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@symphony-jean-michael each changelog entry needs to include a Github PR that introduced the change (e.g. addition or removal)
CHANGELOG.md
Outdated
* Added a context type representing a chat message (`fdc3.chat.message`). ([#794](https://github.com/finos/FDC3/pull/794)) | ||
* Added a context type representing a chat room (`fdc3.chat.room`). ([#794](https://github.com/finos/FDC3/pull/794)) | ||
* Added a chat `Message` type in order to describe messages with rich content and attachments | ||
* Added an `Action` type, encapsulating either a `Context` or the association of a `Context` with an `Intent` inside another object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as previous comment.
CHANGELOG.md
Outdated
### Changed | ||
|
||
* Updated definition of the `ChatInitSettings` context type to use the new `Message` type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as previous comment.
} | ||
} | ||
|
||
## See Also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of text is also included in the example section. Needs to be moved outside of the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on this one @symphony-jean-michael, just need reviewing.
Hi @mistryvinay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Hi @mistryvinay |
…extrade/FDC3 into nemery-flextrade-644-context-type-order
…ata-and-intents-consolidated-update-branch-2.1
…' into Symphony_2.1-candidates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
06ff641
to
ab3660d
Compare
0803274
into
finos:context-data-and-intents-consolidated-update-branch-2.1
As discussed at the last working group (See #868), I created this new PR containing the following PRs: