Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make chatInitSettings inherit from Context #869

Merged
merged 2 commits into from
Mar 22, 2023
Merged

make chatInitSettings inherit from Context #869

merged 2 commits into from
Mar 22, 2023

Conversation

Yannick-Malins
Copy link
Contributor

fixes #852

@netlify
Copy link

netlify bot commented Nov 30, 2022 •
edited
Loading

✅ Deploy Preview for lambent-kulfi-cf51a7 canceled.

Name Link
🔨 Latest commit 863436f
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/638732383a535300091843e6

@kriswest kriswest mentioned this pull request Dec 5, 2022
Closed
@mistryvinay mistryvinay mentioned this pull request Dec 5, 2022
Closed
9 tasks
@mistryvinay mistryvinay added the Context Data & Intents Contexts & Intents Discussion Group label Dec 7, 2022
mistryvinay
mistryvinay approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mistryvinay
Copy link
Contributor

mistryvinay commented Dec 14, 2022 •
edited
Loading

hi @Yannick-Symphony just one more update required for this PR. Currently there is the use of the reserved word public in the schema. This is causing issues when the schema is being built (#869)

"public": "boolean",

Could we change this to something else, maybe isPublic? Note any changes to this will affect PR #882

@symphony-jean-michael
Copy link
Contributor

Hi @mistryvinay
It seems I already fixed the 'public' reserved word in the other PR #875 (Fixing bug #855)
So, there is no need to include it in this PR 😉
(cc @Yannick-Symphony )

@mistryvinay mistryvinay mentioned this pull request Jan 3, 2023
Closed
8 tasks
@mistryvinay mistryvinay mentioned this pull request Jan 31, 2023
Closed
8 tasks
@mistryvinay mistryvinay mentioned this pull request Feb 27, 2023
Closed
15 tasks
kriswest
kriswest approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest mentioned this pull request Mar 20, 2023
Closed
26 tasks
@mistryvinay mistryvinay changed the base branch from master to context-data-and-intents-consolidated-update-branch-2.1 March 22, 2023 13:20
@mistryvinay mistryvinay merged commit b9efdac into finos:context-data-and-intents-consolidated-update-branch-2.1 Mar 22, 2023
@bingenito bingenito mentioned this pull request Nov 6, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistryvinay mistryvinay mistryvinay approved these changes

@kriswest kriswest kriswest approved these changes

Assignees
No one assigned
Labels
Context Data & Intents Contexts & Intents Discussion Group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fdc3.ChatInitSettings is missing id and type is incorrectly defined
4 participants
@Yannick-Malins @mistryvinay @symphony-jean-michael @kriswest