Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/855 Fix incorrect format and rename 'public' property #875

Conversation

symphony-jean-michael
Copy link
Contributor

Fix issue: #855

Changes

  • Fix incorrect schema format
  • Rename 'public' property name because 'public' is a reserved word in JS/Typescript.

See comment: #855 (comment)

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for lambent-kulfi-cf51a7 ready!

Name Link
🔨 Latest commit ed9fd59
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/638f03c582eda30008bf8d89
😎 Deploy Preview https://deploy-preview-875--lambent-kulfi-cf51a7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest mentioned this pull request Mar 20, 2023
26 tasks
@mistryvinay mistryvinay changed the base branch from master to context-data-and-intents-consolidated-update-branch-2.1 March 22, 2023 13:21
@mistryvinay mistryvinay merged commit 907dd79 into finos:context-data-and-intents-consolidated-update-branch-2.1 Mar 22, 2023
@bingenito bingenito mentioned this pull request Nov 6, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context Data & Intents Contexts & Intents Discussion Group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Should ChatInitSettings options have a exported interface
3 participants