Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/855 Fix incorrect format and rename 'public' property #875

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/context/ref/ChatInitSettings.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ https://fdc3.finos.org/schemas/next/chatInitSettings.schema.json
| `members` | ContactList | No | ContactList - cf. below |
| `initMessage` | string | No | `'Hello!'` |
| `options.groupRecipients` | boolean | No | `true`: if false a separate chat will be created for each member |
| `options.public` | boolean | No | `true`: the room will be visible to everyone in the chat application |
| `options.isPublic` | boolean | No | `true`: the room will be visible to everyone in the chat application |
| `options.allowHistoryBrowsing` | boolean | No | `true`: members will be allowed to browse past messages |
| `options.allowMessageCopy` | boolean | No | `true`: members will be allowed to copy/paste messages |
| `options.allowAddUser` | boolean | No | `true`: members will be allowed to add other members to the chat |
Expand Down Expand Up @@ -58,7 +58,7 @@ const initSettings = {
},
options: {
groupRecipients: true, // one chat with both contacts
public: false, // private chat room
isPublic: false, // private chat room
allowHistoryBrowsing: true,
allowMessageCopy: true
}
Expand Down
2 changes: 1 addition & 1 deletion docs/intents/ref/StartChat.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const initSettings = {
},
options: {
groupRecipients: true, // one chat with both contacts
public: false, // private chat room
isPublic: false, // private chat room
allowHistoryBrowsing: true,
allowMessageCopy: true,
allowAddUser: false, // John won't be authorized to add other users to the chat
Expand Down
13 changes: 8 additions & 5 deletions src/context/schemas/chatInitSettings.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
"type": "string"
},
"options": {
"groupRecipients": "boolean",
"public": "boolean",
"allowHistoryBrowsing": "boolean",
"allowMessageCopy": "boolean",
"allowAddUser": "boolean"
"type": "object",
"properties": {
"groupRecipients": {"type": "boolean"},
"isPublic": {"type": "boolean"},
"allowHistoryBrowsing": {"type": "boolean"},
"allowMessageCopy": {"type": "boolean"},
"allowAddUser": {"type": "boolean"}
}
}
},
"required": [
Expand Down
13 changes: 8 additions & 5 deletions website/static/schemas/2.0/chatInitSettings.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
"type": "string"
},
"options": {
"groupRecipients": "boolean",
"public": "boolean",
"allowHistoryBrowsing": "boolean",
"allowMessageCopy": "boolean",
"allowAddUser": "boolean"
"type": "object",
"properties": {
"groupRecipients": {"type": "boolean"},
"public": {"type": "boolean"},
"allowHistoryBrowsing": {"type": "boolean"},
"allowMessageCopy": {"type": "boolean"},
"allowAddUser": {"type": "boolean"}
}
}
},
"required": [
Expand Down
13 changes: 8 additions & 5 deletions website/static/schemas/next/chatInitSettings.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
"type": "string"
},
"options": {
"groupRecipients": "boolean",
"public": "boolean",
"allowHistoryBrowsing": "boolean",
"allowMessageCopy": "boolean",
"allowAddUser": "boolean"
"type": "object",
"properties": {
"groupRecipients": {"type": "boolean"},
"public": {"type": "boolean"},
"allowHistoryBrowsing": {"type": "boolean"},
"allowMessageCopy": {"type": "boolean"},
"allowAddUser": {"type": "boolean"}
}
}
},
"required": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ https://fdc3.finos.org/schemas/2.0/chatInitSettings.schema.json
| `members` | ContactList | No | ContactList - cf. below |
| `initMessage` | string | No | `'Hello!'` |
| `options.groupRecipients` | boolean | No | `true`: if false a separate chat will be created for each member |
| `options.public` | boolean | No | `true`: the room will be visible to everyone in the chat application |
| `options.isPublic` | boolean | No | `true`: the room will be visible to everyone in the chat application |
| `options.allowHistoryBrowsing` | boolean | No | `true`: members will be allowed to browse past messages |
| `options.allowMessageCopy` | boolean | No | `true`: members will be allowed to copy/paste messages |
| `options.allowAddUser` | boolean | No | `true`: members will be allowed to add other members to the chat |
Expand Down Expand Up @@ -59,7 +59,7 @@ const initSettings = {
},
options: {
groupRecipients: true, // one chat with both contacts
public: false, // private chat room
isPublic: false, // private chat room
allowHistoryBrowsing: true,
allowMessageCopy: true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const initSettings = {
},
options: {
groupRecipients: true, // one chat with both contacts
public: false, // private chat room
isPublic: false, // private chat room
allowHistoryBrowsing: true,
allowMessageCopy: true,
allowAddUser: false, // John won't be authorized to add other users to the chat
Expand Down