Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of #475 and prepare release 2.1.3 #478

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Backport of #475 and prepare release 2.1.3 #478

merged 3 commits into from
Mar 17, 2021

Conversation

symphony-youri
Copy link
Contributor

symphony-youri and others added 2 commits March 17, 2021 11:07
@symphony-youri
Fix ConcurrentModificationException in Datafeed loop finos#475 (finos…
072dee2 
…#476)

A ConcurrentModificationException can happen in the Datafeed (DF) loop upon startup.
The access to the listeners collection in the DF loop is not protected
and accessed by multiple threads.

Because of the for loop we need to synchronize on the list itself.

(cherry picked from commit c9fc39c)
@symphony-youri
Prepare 2.1.3 release
c84e9ab
@symphony-youri symphony-youri requested a review from a team as a code owner March 17, 2021 10:08
@symphony-elias
Copy link
Contributor

Shouldn't we ship #474 as well ?

@symphony-youri
Update Spring Boot to 2.4.3 (finos#474)
e7deb03 
This fixes security vulnerabilities reported by Snyk.

Along the way we lost the javax.annotation.Generated classes, add it
explictely as a dependency.

(cherry picked from commit ba4ad60)
@symphony-youri
Copy link
Contributor Author

Shouldn't we ship #474 as well ?

👍, I added it

symphony-elias
symphony-elias approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@symphony-elias symphony-elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thibauult
thibauult approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@thibauult thibauult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for release!

@symphony-youri symphony-youri merged commit b75f440 into finos:2.1-rc Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphony-elias symphony-elias symphony-elias approved these changes

@thibauult thibauult thibauult approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@symphony-youri @symphony-elias @thibauult