Skip to content

Conversation

@SUPERCILEX
Copy link
Collaborator

We want it to be overridden.

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@samtstern
Copy link
Contributor

Thanks! Good catch.

@samtstern samtstern merged commit 9aadfe0 into firebase:version-2.1.1-dev Jul 21, 2017
@SUPERCILEX SUPERCILEX deleted the activity_name branch July 21, 2017 21:06
@WillieCubed
Copy link
Contributor

Hey, we should probably document this since we're requiring an app_name string to override the library's. Is the best idea for usability, though?

@samtstern
Copy link
Contributor

@SUPERCILEX there was no behavior change in recent versions regarding app_name right?

@SUPERCILEX
Copy link
Collaborator Author

@samtstern Nope, we've always used app_name because it's the default thing for AppCompat. We should probably put it on our mental list of stuff to fail the build in v3.0 if the dev doesn't supply it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants