Skip to content

Fix AuthMethodPickerActivity title being "ui_flow" instead of app name #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtstern merged 1 commit into from
Jul 21, 2017
Merged

Fix AuthMethodPickerActivity title being "ui_flow" instead of app name #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@

<activity
android:name="com.facebook.FacebookActivity"
android:label="@string/fui_app_name"
android:label="@string/app_name"
android:configChanges="keyboard|keyboardHidden|screenLayout|screenSize|orientation"
tools:ignore="MissingRegistered" />

Expand Down
6 changes: 3 additions & 3 deletions auth/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
<string name="fui_app_name" translatable="false">ui_flow</string>
<resources xmlns:tools="http://schemas.android.com/tools" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
<string name="app_name" translatable="false" tools:ignore="ResourceName">ui_flow</string>

<!-- Common -->
<string name="fui_default_toolbar_title" translatable="false">@string/fui_app_name</string>
<string name="fui_default_toolbar_title" translatable="false">@string/app_name</string>
<string name="fui_progress_dialog_loading" translation_description="Loading text in dialog">Loading…</string>
<string name="fui_sign_in_default" translation_description="Button text to sign in">Sign in</string>
<string name="fui_general_error" translation_description="Toast text flashing general error">An error has occurred.</string>
Expand Down