Merging firebase-dataconnect to main #6288

dconeybe · 2024-09-20T23:29:49Z

No description provided.

…ists of Int64 and Timestamp, since b/335903750 has been fixed (#546)

…ad of apply(from = "../gradle/googleServices.gradle")

…ing sent, but should have been sent as null (#550)

…that fail due to lack of null list support in the backend (b/337312723) (#552)

…with v1main, v1alpha, etc.

…arked as optional

…anged to required in the previous commit (d9da8a4)

…Test so that it passes consistently (#555)

…ypedDataIntegrationTest.kt

…uth emulator, since the auth emulator startup is slow

…alars.

…Manager" to just "QueryManager"

…taconnect:generateApiTxtFile

github-actions · 2024-09-20T23:30:04Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2024-09-20T23:30:30Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

github-actions · 2024-09-20T23:46:28Z

Unit Test Results

  901 files +  893   901 suites +893 32m 49s ⏱️ + 32m 21s
4 851 tests +4 829 4 830 ✔️ +4 808 21 💤 +21 0 ❌ ±0
9 760 runs +9 716 9 718 ✔️ +9 674 42 💤 +42 0 ❌ ±0

Results for commit 2110dae. ± Comparison against base commit da0eefa.

google-oss-bot · 2024-09-20T23:51:39Z

Size Report ¹

Affected Products

firebase-common
Type Base (da0eefa) Merge (2ef2464) Diff
apk (release) 4.40 MB 4.45 MB +46.9 kB (+1.1%)
firebase-common-ktx
Type Base (da0eefa) Merge (2ef2464) Diff
apk (release) 4.40 MB 4.45 MB +46.9 kB (+1.1%)
firebase-database
Type Base (da0eefa) Merge (2ef2464) Diff
aar 543 kB 542 kB -41 B (-0.0%)
apk (release) 5.29 MB 5.34 MB +47.1 kB (+0.9%)
firebase-database-ktx
Type Base (da0eefa) Merge (2ef2464) Diff
apk (release) 5.29 MB 5.34 MB +47.1 kB (+0.9%)
firebase-dataconnect
Type Base (da0eefa) Merge (2ef2464) Diff
aar ? 641 kB ? (?)
apk (aggressive) ? 520 kB ? (?)
apk (release) ? 11.0 MB ? (?)
firebase-firestore
Type Base (da0eefa) Merge (2ef2464) Diff
aar 1.44 MB 1.44 MB +404 B (+0.0%)
apk (release) 11.3 MB 11.4 MB +47.1 kB (+0.4%)
firebase-firestore-ktx
Type Base (da0eefa) Merge (2ef2464) Diff
apk (release) 11.3 MB 11.4 MB +47.1 kB (+0.4%)
firebase-storage
Type Base (da0eefa) Merge (2ef2464) Diff
apk (release) 4.99 MB 5.04 MB +47.1 kB (+0.9%)
firebase-storage-ktx
Type Base (da0eefa) Merge (2ef2464) Diff
apk (release) 4.99 MB 5.04 MB +47.1 kB (+0.9%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/CRoJ9lUGOO.html

google-oss-bot · 2024-09-21T00:11:57Z

Coverage Report ¹

Affected Products

`firebase-config`

Overall coverage changed from ? (da0eefa) to 84.11% (2ef2464) by ?.

33 individual files with coverage change

Filename	Base (`da0eefa`)	Merge (`2ef2464`)	Diff
AutoValue_ConfigUpdate.java	?	29.41%	?
Code.java	?	0.00%	?
ConfigAutoFetch.java	?	87.74%	?
ConfigCacheClient.java	?	93.33%	?
ConfigContainer.java	?	94.29%	?
ConfigFetchHandler.java	?	92.86%	?
ConfigFetchHttpClient.java	?	87.33%	?
ConfigGetParameterHandler.java	?	96.45%	?
ConfigMetadataClient.java	?	92.31%	?
ConfigRealtimeHandler.java	?	41.38%	?
ConfigRealtimeHttpClient.java	?	68.93%	?
ConfigStorageClient.java	?	100.00%	?
ConfigUpdate.java	?	100.00%	?
ConfigUpdateListener.java	?	0.00%	?
ConfigUpdateListenerRegistration.java	?	0.00%	?
DefaultsXmlParser.java	?	0.00%	?
FirebaseRemoteConfig.java	?	89.52%	?
FirebaseRemoteConfigClientException.java	?	75.00%	?
FirebaseRemoteConfigException.java	?	95.65%	?
FirebaseRemoteConfigFetchThrottledException.java	?	100.00%	?
FirebaseRemoteConfigInfo.java	?	0.00%	?
FirebaseRemoteConfigInfoImpl.java	?	100.00%	?
FirebaseRemoteConfigServerException.java	?	68.42%	?
FirebaseRemoteConfigSettings.java	?	61.54%	?
FirebaseRemoteConfigValue.java	?	0.00%	?
FirebaseRemoteConfigValueImpl.java	?	84.62%	?
Personalization.java	?	91.43%	?
RemoteConfig.kt	?	31.58%	?
RemoteConfigComponent.java	?	90.70%	?
RemoteConfigConstants.java	?	0.00%	?
RemoteConfigRegistrar.java	?	100.00%	?
RolloutsStateFactory.java	?	95.24%	?
RolloutsStateSubscriptionsHandler.java	?	100.00%	?

firebase-database
Overall coverage changed from 50.16% (da0eefa) to 50.21% (2ef2464) by +0.04%.
Filename Base (da0eefa) Merge (2ef2464) Diff
ChildChangeAccumulator.java 83.33% 96.67% +13.33%
firebase-firestore
Overall coverage changed from 46.06% (da0eefa) to 46.05% (2ef2464) by -0.01%.
Filename Base (da0eefa) Merge (2ef2464) Diff
LruGarbageCollector.java 97.27% 93.64% -3.64%
SetMutation.java 94.44% 97.22% +2.78%
firebase-messaging
Overall coverage changed from 84.24% (da0eefa) to 84.28% (2ef2464) by +0.04%.
Filename Base (da0eefa) Merge (2ef2464) Diff
FirebaseMessaging.java 76.80% 76.00% -0.80%
Metadata.java 36.51% 41.27% +4.76%
firebase-ml-modeldownloader
Overall coverage changed from 83.32% (da0eefa) to 83.38% (2ef2464) by +0.06%.
Filename Base (da0eefa) Merge (2ef2464) Diff
FirebaseModelDownloader.java 84.05% 84.66% +0.61%
firebase-storage
Overall coverage changed from 84.33% (da0eefa) to 83.96% (2ef2464) by -0.37%.
Filename Base (da0eefa) Merge (2ef2464) Diff
StorageException.java 69.09% 65.45% -3.64%
StorageTask.java 83.99% 83.38% -0.60%
UploadTask.java 83.17% 81.52% -1.65%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/qeQs9bxUKW.html

google-oss-bot · 2024-09-21T00:30:05Z

Startup Time Report ¹

The report is too large (122,652 chars) to be displayed on GitHub. Please check this report on GCS.

https://storage.googleapis.com/firebase-sdk-metric-reports/a4IjRlaB0Z/index.html

dconeybe added 30 commits April 24, 2024 16:14

Int64 tests (#545)

ba0058e

ScalarVariablesAndDataIntegrationTest.kt: re-enable tests for empty l…

386225a

…ists of Int64 and Timestamp, since b/335903750 has been fixed (#546)

KeyVariablesIntegrationTest.kt: added test: primaryKeyIsNested() (#547)

28bafec

Merge remote-tracking branch 'public/master' into dataconnect

f8cf2cb

firebase-dataconnect.gradle.kts: use id("copy-google-services") inste…

a085df6

…ad of apply(from = "../gradle/googleServices.gradle")

Add integration tests for "on" and "via" relations (#548)

552eb73

Merge remote-tracking branch 'public/master' into dataconnect

ea5691e

demo_ops.gql created by merging demo_foo_ops.gql and demo_scalar_ops.gql

5731997

gradle.properties: set version to 0.0.1-dev

f802fed

Logger.kt: include version in log messages

e695b85

Set version to 0.0.1 (#549)

58227ed

Set version to 0.0.2-dev

d31b005

ProtoStructEncoder.kt: fix bug where null variable values were not be…

9786180

…ing sent, but should have been sent as null (#550)

Merge remote-tracking branch 'public/master' into dataconnect

060f1df

TimestampSerializer.kt: fix and increase unit test coverage (#551)

53edd9b

DataConnectUntypedResponseIntegrationTest.kt: comment out test cases …

974ff02

…that fail due to lack of null list support in the backend (b/337312723) (#552)

Merge remote-tracking branch 'public/master' into dataconnect

c6a26ad

DataConnectGrpcClient.kt: include full RPC name in log message

bd9fd5e

Change directory and Java package of proto files, to avoid confusion …

155e672

…with v1main, v1alpha, etc.

demo_ops.gql: make query parameters required that were accidentally m…

d9da8a4

…arked as optional

Update generated code that was missed when optional variables were ch…

85a193c

…anged to required in the previous commit (d9da8a4)

Merge remote-tracking branch 'public/master' into dataconnect

d430d71

Change dependencies to public versions in gradle build scripts (#554)

f312a9a

upgrade firebase-auth dependency to the latest, 22.3.1 (was 20.0.0)

188af0e

Refactor data connect auth code, and, especially, fix AuthIntegration…

33064cd

…Test so that it passes consistently (#555)

Rename DataConnectUntypedResponseIntegrationTest.kt -> DataConnectUnt…

07b6368

…ypedDataIntegrationTest.kt

Update for UUID strings without dashes (#556)

acd6e7a

emulator.sh: provide an easy way to launch the emulator without the a…

96ce0fd

…uth emulator, since the auth emulator startup is slow

DataConnectSettings.kt: add STAGING_DATACONNECT_HOST

c34b0f9

DataConnectSettings.kt: AUTOPUSH_DATACONNECT_HOST added

4ca6482

dconeybe added 17 commits September 10, 2024 16:52

Merge remote-tracking branch 'origin/main' into dataconnect

cb19122

switch back to us-central1, since its App Check enforcement now works

106cb6a

Merge remote-tracking branch 'origin/main' into dataconnect

9e1912c

Merge remote-tracking branch 'origin/main' into dataconnect

408a513

Merge remote-tracking branch 'origin/main' into dataconnect

7cb6c47

Remove the defunct demo code

d752534

rename plugin to gradleplugin

a52410e

Merge remote-tracking branch 'origin/main' into dataconnect

3552bf4

Merge remote-tracking branch 'origin/main' into dataconnect

dfa2340

Merge remote-tracking branch 'origin/main' into dataconnect

ce7fb34

Overhaul AnyScalarIntegrationTest.kt (#6283)

22a34d1

gradleplugin: add support for 1.3.6 and 1.3.7

23cb8e2

Merge remote-tracking branch 'origin/main' into dataconnect

8d86ef2

gradleplugin: add support for 1.3.8, which fixes codegen for Any sc…

7b01d88

…alars.

Delete the "new" QueryManager, which was unused, and rename "OldQuery…

30c95d9

…Manager" to just "QueryManager"

updated firebase-dataconnect/api.txt by running ./gradlew firebase-da…

dd5a27b

…taconnect:generateApiTxtFile

Merge branch 'dataconnect' into dataconnect-merge_to_main

2110dae

dconeybe self-assigned this Sep 20, 2024

google-oss-bot added the do-not-merge/work-in-progress label Sep 20, 2024

google-oss-bot added the size/XXL label Sep 20, 2024

dconeybe added the main-merge-ack label Sep 20, 2024

dconeybe closed this Sep 21, 2024

dconeybe deleted the dataconnect-merge_to_main branch September 21, 2024 01:44

firebase locked and limited conversation to collaborators Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging firebase-dataconnect to main #6288

Merging firebase-dataconnect to main #6288

dconeybe commented Sep 20, 2024

github-actions bot commented Sep 20, 2024 •

edited

Loading

google-oss-bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

google-oss-bot commented Sep 20, 2024

`firebase-common`

`firebase-common-ktx`

`firebase-database`

`firebase-database-ktx`

`firebase-dataconnect`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-storage`

`firebase-storage-ktx`

google-oss-bot commented Sep 21, 2024

`firebase-config`

`firebase-database`

`firebase-firestore`

`firebase-messaging`

`firebase-ml-modeldownloader`

`firebase-storage`

google-oss-bot commented Sep 21, 2024

Merging firebase-dataconnect to main #6288

Merging firebase-dataconnect to main #6288

Conversation

dconeybe commented Sep 20, 2024

github-actions bot commented Sep 20, 2024 • edited Loading

📝 PRs merging into main branch

google-oss-bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

Unit Test Results

google-oss-bot commented Sep 20, 2024

Size Report 1

Affected Products

firebase-common

firebase-common-ktx

firebase-database

firebase-database-ktx

firebase-dataconnect

firebase-firestore

firebase-firestore-ktx

firebase-storage

firebase-storage-ktx

Test Logs

google-oss-bot commented Sep 21, 2024

Coverage Report 1

Affected Products

firebase-config

firebase-database

firebase-firestore

firebase-messaging

firebase-ml-modeldownloader

firebase-storage

Test Logs

google-oss-bot commented Sep 21, 2024

Startup Time Report 1

github-actions bot commented Sep 20, 2024 •

edited

Loading

Size Report ¹

`firebase-common`

`firebase-common-ktx`

`firebase-database`

`firebase-database-ktx`

`firebase-dataconnect`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-storage`

`firebase-storage-ktx`

Coverage Report ¹

`firebase-config`

`firebase-database`

`firebase-firestore`

`firebase-messaging`

`firebase-ml-modeldownloader`

`firebase-storage`

Startup Time Report ¹