Merge 7.0.0 to dev #209

DellaBitta · 2020-12-10T16:53:56Z

Merging code from main branch (6.16.0 release) to dev.

Resolved 123 merge conflicts.

PiperOrigin-RevId: 316809187

…lay mode. FutureProxyManager still grabs FutureHandle that supposed to be cleaned up and released. Force release them during proxy manager's destructor. PiperOrigin-RevId: 316809477

PiperOrigin-RevId: 317136423

…m 6.26.0 PiperOrigin-RevId: 317141369

PiperOrigin-RevId: 317141369

…-src

Add empty workflow to manually trigger.

Also fixes a flaky test because assertion is some times done before expected remote event arrives. PiperOrigin-RevId: 317154095

…g predicates. See b/158478280 and go/absl-cleanup-lsc for more details. This change was produced using rename_function with the spec: rename { rename_spec { new_header: "third_party/absl/strings/str_split.h" old_name: "strings::Split" new_name: "absl::StrSplit" } } Additionally, a global find/replace was done on: strings::AllowEmpty -> absl::AllowEmpty strings::SkipEmpty -> absl::SkipEmpty strings::SkipWhitespace -> absl::SkipWhitespace Tested: TAP sample presubmit queue http://test/OCL:317011231:BASE:317041434:1592460837225:fc71f604 PiperOrigin-RevId: 317399788

PiperOrigin-RevId: 317402209

*** Reason for rollback *** Not ready for release yet *** Original change description *** Add a user callback executor for android. Also fixes a flaky test because assertion is some times done before expected remote event arrives. *** PiperOrigin-RevId: 317736475

*** Reason for rollback *** Not ready for release yet *** Original change description *** [C++] Provide a default executor with settings on iOS *** PiperOrigin-RevId: 317791137

Also fix a memory leak during listener unregistration PiperOrigin-RevId: 318538053

Fix leaks in firestore_test that the HeapChecker found. Test with `blaze test -c dbg` to get line numbers in stack frames. PiperOrigin-RevId: 318644593

PiperOrigin-RevId: 318885157

*** Reason for rollback *** re-roll cl/317154095 SKIP_FIRESTORE_KOKORO_BUILD_TEST=true *** Original change description *** Automated g4 rollback of changelist 317154095. *** Reason for rollback *** Not ready for release yet *** Original change description *** Add a user callback executor for android. Also fixes a flaky test because assertion is some times done before expected remote event arrives. *** *** PiperOrigin-RevId: 318891491

PiperOrigin-RevId: 318899934

*** Reason for rollback *** Re-roll cl/314233757 SKIP_FIRESTORE_KOKORO_BUILD_TEST=true *** Original change description *** Automated g4 rollback of changelist 314233757. *** Reason for rollback *** Not ready for release yet *** Original change description *** [C++] Provide a default executor with settings on iOS *** *** PiperOrigin-RevId: 318938740

There are several related flaws fixed here: * The mutex in TestEventListener was not applied consistently, leading to data races that showed up as strangely failing tests on forge. * The result of FirestoreIntegrationTest::Await was implicitly trusted to produce some results, but this isn't the case when it times out. In this error case the caller would read uninitialized memory almost immediately after, leading to crashes before the log message about the timeout had necessarily been writen. * The result of FirestoreIntegrationTest::Await was implicitly trusted not to produce more results than requested, but this didn't always happen either. This would cause failures where a test would request `n` events, and use the last `n` that arrived, skipping extra events. Now the EventAccumulator ensures that it consumes events in sequence. PiperOrigin-RevId: 318943435

Certain tests include a warm-up step to ensure that the backend was actually available, but only waited for any event. Unfortunately this doesn't work, because when the server is unavailable, the SDK will serve a from-cache event indicating the document doesn't exist. Change all these to wait for a from-cache: false event, guaranteeing that the server is actually available and confirming the document doesn't exist. PiperOrigin-RevId: 318948824

This simplifies the specification of promises, cleanup functions, and converters, since they now only need to specify the public type. PiperOrigin-RevId: 318960642

This makes promise creation more closely match iOS and paves the way for removing WrapperFuture altogether. Use PromiseFactory in all internal type implementations instead of extending WrapperFuture and then dDelete WrapperFuture. PiperOrigin-RevId: 319025783

PiperOrigin-RevId: 319034882

Previously, setting FirebaseFirestore.LogLevel to LogLevel.Debug would get bumped back to LogLevel.Info as an unexpected side effect of creating of a new firebase::App object. The apparent effect to users was that enabling debug logging had no effect. This made it challenging to debug issues with customers because they were unable to collect valuable debug logs when using iOS as their platform. PiperOrigin-RevId: 319056991

This CL is the last in a series described in cl/312713181, cl/317397413, and resolves b/156024690. In this CL the new pattern for managing listener callbacks implemented in `FirebaseFirestore.ListenForSnapshotsInSync()` is being applied to all other places where we expose listeners (i.e. `Query` and `DocumentReference`). PiperOrigin-RevId: 319089024

THIS CHANGE IS BELIEVED SAFE Templated asynchronous code can change the lifetime of string data as a result of this change; however, the most common uses of these (lambdas and callbacks) are excluded from this change. Further, your TAP tests pass. go/string-ref-to-string-view-lsc Tested: TAP --sample ran all affected tests and none failed http://test/OCL:319219698:BASE:319213711:1593616691507:a583f044 PiperOrigin-RevId: 319286243

This has been observed during cleanup when a DocumentReferenceInternal is destroyed, its Future API can end up deleting orphaned Future APIs that contain Futures holding the containing `DocumentReference`. PiperOrigin-RevId: 320260380

- Replaced std mutex with our own app mutex in app/src/heartbeat_date_storage_desktop.cc. - Removed heartbeat code from Android builds.

google-cla · 2020-12-16T17:35:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-16T17:35:54Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vimanyu

nit: end of file new lines
LGTM otherwise.

vimanyu · 2020-12-15T22:07:10Z

admob/admob_resources/build.gradle

 }

 afterEvaluate {
  generateReleaseBuildConfig.enabled = false
 }

 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
-extractAndDexAarFile('admob_resources')
+extractAndDexAarFile('admob_resources')


nit:newline at end of file

vimanyu · 2020-12-15T22:07:34Z

app/app_resources/build.gradle

 }

 afterEvaluate {
  generateReleaseBuildConfig.enabled = false
 }

 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
-extractAndDexAarFile('app_resources')
+extractAndDexAarFile('app_resources')


nit:newline at end of file

vimanyu · 2020-12-15T22:07:41Z

app/google_api_resources/build.gradle

@@ -59,4 +59,4 @@ afterEvaluate {
 }

 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
-extractAndDexAarFile('google_api_resources')
+extractAndDexAarFile('google_api_resources')


nit:newline at end of file

vimanyu · 2020-12-15T22:07:47Z

app/invites_resources/build.gradle

@@ -55,4 +55,4 @@ afterEvaluate {
 }

 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
-extractAndDexAarFile('invites_resources')
+extractAndDexAarFile('invites_resources')


nit:newline at end of file

sunmou99 · 2020-12-16T21:04:03Z

firestore/src/ios/firebase_metadata_provider_desktop.h

@@ -0,0 +1,18 @@
+#ifndef FIREBASE_FIRESTORE_CLIENT_CPP_SRC_IOS_FIREBASE_METADATA_PROVIDER_DESKTOP_H_
+#define FIREBASE_FIRESTORE_CLIENT_CPP_SRC_IOS_FIREBASE_METADATA_PROVIDER_DESKTOP_H_


It seems the file name doesn't consist with the path. Looks like a desktop files under ios path?

google-cla · 2020-12-16T21:23:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

DellaBitta · 2020-12-16T22:03:35Z

nit: end of file new lines
LGTM otherwise.

Yep, the end of file problems came straight out of the internal repo. I'm working on a CL to push buid fixes made here back into the internal repo. I'll be sure to add new lines to these files. Thanks!

google-cla · 2020-12-17T14:49:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

DellaBitta · 2020-12-17T16:28:29Z

@googlebot I fixed it.

google-cla · 2020-12-17T16:29:55Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

wu-hui and others added 30 commits June 18, 2020 14:52

Use Executor::CreateSerial

2a65cd1

PiperOrigin-RevId: 316809187

Fix future crash that cause unity editor to crash second time enter p…

6b100bc

…lay mode. FutureProxyManager still grabs FutureHandle that supposed to be cleaned up and released. Force release them during proxy manager's destructor. PiperOrigin-RevId: 316809477

Fix integration test caused by curl http2 default setting

a397c96

PiperOrigin-RevId: 317136423

Pin the Firestore pod used by the open source repo to the version fro…

f6e6443

…m 6.26.0 PiperOrigin-RevId: 317141369

Project import generated by Copybara.

fdd27b5

PiperOrigin-RevId: 317141369

Add unit tests for the Firebase libraries

598f485

PiperOrigin-RevId: 317141369

Merge branch 'master' of sso://devrel/libraries/firebase/cpp-firebase…

45cad30

…-src

Merge remote-tracking branch 'origin/master' into ghm

1d13237

Add empty workflow to manually trigger.

aed558e

Merge pull request #94 from firebase/feature/js-noop-yml

cd4ce2f

Add empty workflow to manually trigger.

Add a user callback executor for android.

67642c8

Also fixes a flaky test because assertion is some times done before expected remote event arrives. PiperOrigin-RevId: 317154095

Incremented version numbers to 6.15.1

8fdca57

PiperOrigin-RevId: 317402209

Automated g4 rollback of changelist 314233757.

51f027c

*** Reason for rollback *** Not ready for release yet *** Original change description *** [C++] Provide a default executor with settings on iOS *** PiperOrigin-RevId: 317791137

Fix a missing call to ClearListeners in ~FirestoreInternal.

a46c63a

Also fix a memory leak during listener unregistration PiperOrigin-RevId: 318538053

Enable full stack traces for crashes in unit tests

cef677b

Fix leaks in firestore_test that the HeapChecker found. Test with `blaze test -c dbg` to get line numbers in stack frames. PiperOrigin-RevId: 318644593

Hooked up Persistence into Realtime Database.

f62c57a

PiperOrigin-RevId: 318885157

Removed errant include.

e1483fe

PiperOrigin-RevId: 318899934

Implement type map for public to internal types

fef5d47

This simplifies the specification of promises, cleanup functions, and converters, since they now only need to specify the public type. PiperOrigin-RevId: 318960642

Remove LastResult implementations

69e733e

PiperOrigin-RevId: 319034882

DellaBitta added 2 commits December 16, 2020 12:33

Fixes for packaging steps (#215)

a7342a8

- Replaced std mutex with our own app mutex in app/src/heartbeat_date_storage_desktop.cc. - Removed heartbeat code from Android builds.

Merge branch 'dev' into merge-m83

e8d515b

google-cla bot added cla: no and removed cla: yes labels Dec 16, 2020

DellaBitta added cla: yes and removed cla: no labels Dec 16, 2020

vimanyu approved these changes Dec 16, 2020

View reviewed changes

sunmou99 reviewed Dec 16, 2020

View reviewed changes

Merge branch 'dev' into merge-m83

1515717

google-cla bot added cla: no and removed cla: yes labels Dec 16, 2020

DellaBitta added cla: yes and removed cla: no labels Dec 16, 2020

Merge branch 'dev' into merge-m83

6b7c028

google-cla bot added cla: no and removed cla: yes labels Dec 17, 2020

DellaBitta added cla: yes and removed cla: no labels Dec 17, 2020

DellaBitta merged commit d3a8bcc into dev Dec 17, 2020

DellaBitta deleted the merge-m83 branch December 17, 2020 16:29

google-cla bot added cla: no and removed cla: yes labels Dec 17, 2020

firebase locked and limited conversation to collaborators Jan 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge 7.0.0 to dev #209

Merge 7.0.0 to dev #209

DellaBitta commented Dec 10, 2020

google-cla bot commented Dec 16, 2020

google-cla bot commented Dec 16, 2020

vimanyu left a comment

vimanyu Dec 15, 2020

vimanyu Dec 15, 2020

vimanyu Dec 15, 2020

vimanyu Dec 15, 2020

sunmou99 Dec 16, 2020 •

edited

Loading

google-cla bot commented Dec 16, 2020

DellaBitta commented Dec 16, 2020

google-cla bot commented Dec 17, 2020

DellaBitta commented Dec 17, 2020

google-cla bot commented Dec 17, 2020

		@@ -0,0 +1,18 @@
		#ifndef FIREBASE_FIRESTORE_CLIENT_CPP_SRC_IOS_FIREBASE_METADATA_PROVIDER_DESKTOP_H_
		#define FIREBASE_FIRESTORE_CLIENT_CPP_SRC_IOS_FIREBASE_METADATA_PROVIDER_DESKTOP_H_

Merge 7.0.0 to dev #209

Merge 7.0.0 to dev #209

Conversation

DellaBitta commented Dec 10, 2020

google-cla bot commented Dec 16, 2020

google-cla bot commented Dec 16, 2020

vimanyu left a comment

Choose a reason for hiding this comment

vimanyu Dec 15, 2020

Choose a reason for hiding this comment

vimanyu Dec 15, 2020

Choose a reason for hiding this comment

vimanyu Dec 15, 2020

Choose a reason for hiding this comment

vimanyu Dec 15, 2020

Choose a reason for hiding this comment

sunmou99 Dec 16, 2020 • edited Loading

Choose a reason for hiding this comment

google-cla bot commented Dec 16, 2020

DellaBitta commented Dec 16, 2020

google-cla bot commented Dec 17, 2020

DellaBitta commented Dec 17, 2020

google-cla bot commented Dec 17, 2020

sunmou99 Dec 16, 2020 •

edited

Loading