Skip to content

Merge 7.0.0 to dev #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 193 commits into from
Dec 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
193 commits
Select commit Hold shift + click to select a range
2a65cd1
Use Executor::CreateSerial
wu-hui Jun 17, 2020
6b100bc
Fix future crash that cause unity editor to crash second time enter p…
Jun 17, 2020
a397c96
Fix integration test caused by curl http2 default setting
Jun 18, 2020
f6e6443
Pin the Firestore pod used by the open source repo to the version fro…
a-maurice Jun 18, 2020
fdd27b5
Project import generated by Copybara.
a-googler Jun 18, 2020
598f485
Add unit tests for the Firebase libraries
a-googler Jun 18, 2020
45cad30
Merge branch 'master' of sso://devrel/libraries/firebase/cpp-firebase…
a-maurice Jun 18, 2020
1d13237
Merge remote-tracking branch 'origin/master' into ghm
a-maurice Jun 18, 2020
aed558e
Add empty workflow to manually trigger.
jonsimantov Jul 20, 2020
cd4ce2f
Merge pull request #94 from firebase/feature/js-noop-yml
jonsimantov Jul 20, 2020
67642c8
Add a user callback executor for android.
wu-hui Jun 18, 2020
f9edb56
Migrating deprecated aliases for absl::StrSplit, and the correspondin…
a-googler Jun 19, 2020
8fdca57
Incremented version numbers to 6.15.1
Jun 19, 2020
7b5cc3c
Automated g4 rollback of changelist 317154095.
wilhuff Jun 22, 2020
51f027c
Automated g4 rollback of changelist 314233757.
wilhuff Jun 23, 2020
a46c63a
Fix a missing call to `ClearListeners` in ~FirestoreInternal.
wilhuff Jun 26, 2020
cef677b
Enable full stack traces for crashes in unit tests
wilhuff Jun 27, 2020
f62c57a
Hooked up Persistence into Realtime Database.
Jun 29, 2020
c8fd885
Automated g4 rollback of changelist 317736475.
wu-hui Jun 29, 2020
e1483fe
Removed errant include.
Jun 29, 2020
7a66fc4
Automated g4 rollback of changelist 317791137.
wu-hui Jun 30, 2020
4f01138
Fix issues with event accumulation in Firestore C++ integration tests
wilhuff Jun 30, 2020
c51074d
Fix test warm-up
wilhuff Jun 30, 2020
fef5d47
Implement type map for public to internal types
wilhuff Jun 30, 2020
b1c3695
Split PromiseFactory out of WrapperFuture
wilhuff Jun 30, 2020
69e733e
Remove LastResult implementations
wilhuff Jun 30, 2020
492dffb
Fix enabling debug logging from Unity in iOS.
a-googler Jun 30, 2020
6815e02
Cleanup listener callbacks on `DocumentReference` and `Query`.
a-googler Jun 30, 2020
8714bed
Migrate const std::string& parameters to absl::string_view.
a-googler Jul 1, 2020
a70101c
Avoid double deletion of internal objects during cleanup.
wilhuff Jul 8, 2020
7e62c36
Avoid empty statement warnings in Firebase assertions
wilhuff Jul 8, 2020
eb66965
Miscellaneous test-only fixes
wilhuff Jul 9, 2020
feb21a7
Delete C++ Firestore objects when C# has no more references to them.
a-googler Jul 10, 2020
32ee577
Remove the unconditional calls to Firebase::Terminate() in test cleanup.
a-googler Jul 10, 2020
0827dad
Change std:unique_ptr to UniquePtr
chkuang-g Jul 10, 2020
082c5d2
Update Android deps to latest
chkuang-g Jul 10, 2020
0490b4b
Make test failures in numeric transforms tests easier to read
wilhuff Jul 13, 2020
cb36be5
Add JNI Object wrapper and type conversion traits
wilhuff Jul 13, 2020
30f9b9e
Add JNI ownership types
wilhuff Jul 14, 2020
cdec053
Add FIREventScreenView and params
a-googler Jul 14, 2020
44dbea4
Add another line in the generate constant header script
a-maurice Jul 15, 2020
c4731f4
Add initial Env with minimal support for Strings
wilhuff Jul 16, 2020
3ac9e71
Rework ToJni conversions to enable pass-through of JNI types
wilhuff Jul 17, 2020
667478f
Add support for calling methods and getting fields.
wilhuff Jul 21, 2020
dbe14b6
Merge remote-tracking branch 'origin/master' into ghm
a-maurice Jul 22, 2020
d464bcf
Create dummy workflow for integration tests (#106)
anonymous-akorn Aug 3, 2020
95beec9
Create feature-request.md
chkuang-g Sep 8, 2020
cea22cf
Update and rename firebase-cpp-sdk-issue.md to issue.md
chkuang-g Sep 8, 2020
a577462
Merge pull request #137 from firebase/chkuang-g-patch-3
chkuang-g Sep 8, 2020
abfdb58
Merge branch 'master' into chkuang-g-patch-2
chkuang-g Sep 8, 2020
bfb4ca6
Merge pull request #136 from firebase/chkuang-g-patch-2
chkuang-g Sep 8, 2020
b8f1e9b
Update issue.md
chkuang-g Sep 9, 2020
8d51ba9
Merge pull request #138 from firebase/chkuang-g-patch-4
chkuang-g Sep 9, 2020
e4f99ff
Update issue templates
chkuang-g Sep 19, 2020
700b0a0
Update feature-request.md
chkuang-g Sep 19, 2020
135811e
Merge pull request #149 from firebase/issue-templates-patch
a-maurice Sep 19, 2020
d54325c
Revise string methods to be wrapper-only
wilhuff Jul 23, 2020
ade6db2
Fix deletion of the pointers returned from CreateFirestore().
a-googler Jul 23, 2020
8431f04
Add exception support to Env
wilhuff Jul 23, 2020
15a630e
Add logic to ignore a specific file in Kokoro build logic
a-maurice Jul 28, 2020
c8bc017
Add support for cacheable global declarations of JNI types
wilhuff Jul 29, 2020
9ee98fc
Add support for embedded files and other odds and ends
wilhuff Jul 29, 2020
6bde07c
Convert CollectionReference to new JNI framework
wilhuff Jul 29, 2020
bd7b283
Add C++ proxies for Java standard library types
wilhuff Aug 4, 2020
062faa1
Fix assertion incorrectly checking a moved-from rather than the moved…
var-const Aug 4, 2020
8e9fdbf
Improve `Variant` error message when used with an unsupported type.
var-const Aug 5, 2020
d88c2b4
Add support for creating and manipulating Java arrays to the `JNIEnv`…
wilhuff Aug 5, 2020
afe1e29
Improve the tests for ClearPersistence() to use the default Firebase …
a-googler Aug 6, 2020
b83c1fd
Convert DocumentReference and supporting classes to the new JNI frame…
wilhuff Aug 7, 2020
e9ab209
Rework MapFieldValue and MapFieldPathValue calls
wilhuff Aug 7, 2020
b2f9b5a
Automated g4 rollback of changelist 325229850.
a-googler Aug 12, 2020
ecc9be9
Updated MessageForwardingService to be a JobIntentService for Android O.
Aug 14, 2020
da043d4
Deprecating Send.
Aug 14, 2020
57c9075
LSC: Change for loops to use const refs, per performance-for-range-copy
a-googler Aug 15, 2020
a19ffc2
Update the Android dependencies for M77
a-maurice Aug 20, 2020
546d3fb
Convert DocumentChange to the new JNI framework
wilhuff Aug 20, 2020
7f04dab
Convert ServerTimetampBehavior to new JNI framework
wilhuff Aug 20, 2020
e983cce
Convert SnapshotMetadata to the new JNI framework
wilhuff Aug 21, 2020
6ad447c
Make Unity send Cloud API headers indicating the language version and…
var-const Aug 21, 2020
7e79870
Convert DocumentSnapshot to the new JNI framework
wilhuff Aug 21, 2020
d425f88
Improve the error message that is generated when a Future fails.
a-googler Aug 24, 2020
b5c99dc
Convert Blob to the new JNI framework
wilhuff Aug 28, 2020
502a386
Convert Direction to the new JNI framework
wilhuff Aug 28, 2020
a88486e
Convert Settings to the new JNI framework
wilhuff Sep 2, 2020
435481d
Convert WriteBatch to the new JNI framework
wilhuff Sep 2, 2020
0c728c1
Convert Timestamp to the new JNI framework
wilhuff Sep 2, 2020
a13be5b
Change forward declaration for SignInResult to struct
chkuang-g Sep 3, 2020
1ff5a40
Convert QuerySnapshot to the new JNI framework
wilhuff Sep 4, 2020
5889e73
Update the Android dependencies for M78
a-maurice Sep 8, 2020
65e5703
Re-write `run_local_tests.sh` to run the tests in parallel.
a-googler Sep 9, 2020
33d90f4
Plumb through error messages for Query and Document listens in C++ an…
a-googler Sep 9, 2020
f8240f7
Check that calls to Terminate() and ClearPersistence() actually succeed.
a-googler Sep 9, 2020
721c280
Add logic to detect the compiler version and the C++ language standar…
var-const Sep 14, 2020
ebb43ad
Automated g4 rollback of changelist 326267389.
a-googler Sep 16, 2020
4c13211
Temporarily add a platform token to the Cloud API headers.
var-const Sep 16, 2020
9c7b7c5
Add play-services-base to Android deps for analytics/admob/remote_con…
a-googler Sep 17, 2020
37751e7
Update the Build and Podfiles
a-maurice Sep 17, 2020
3babeb6
Update the version numbers for 6.16.0
a-maurice Sep 18, 2020
a0c292a
Convert GeoPoint to the new JNI framework
wilhuff Sep 22, 2020
1f39b71
Handling `IllegalStateException` when loading or creating interstitia…
a-googler Sep 22, 2020
f32e36e
Convert Query to the new JNI framework
wilhuff Sep 22, 2020
c33ef95
Copybara Firestore
a-googler Sep 22, 2020
61beffe
Added a test for C++ namespace renaming to Blastdoor tests, and added…
jonsimantov Sep 22, 2020
e7363ce
Set the language in Cloud headers to `gl-cpp/` in the C++ SDK on Andr…
var-const Sep 23, 2020
f2105db
Convert FirestoreInternal to the new JNI framework
wilhuff Sep 24, 2020
782ec2a
Convert ListenerRegistration to the new JNI framework
wilhuff Sep 24, 2020
3cc9467
Fix it so only external C++ symbols matching the list of namespaces t…
jonsimantov Sep 24, 2020
d3fe671
Convert EventListener to the new JNI framework
wilhuff Sep 28, 2020
ee4fa72
Clean up exception naming
wilhuff Sep 28, 2020
3282885
Convert ExceptionInternal to the new JNI framework
wilhuff Sep 28, 2020
0acec23
Make snapshot from TransactionGetResult return by value.
wu-hui Sep 29, 2020
66887d6
Add Ad Impression constants to public header
a-googler Sep 29, 2020
be955c6
Finish conversion of TransactionInternal to the new JNI framework
wilhuff Sep 29, 2020
354e637
Add boxed primitive types to the JNI library
wilhuff Sep 29, 2020
dd5966b
Add example to ad unit in header file
a-googler Sep 29, 2020
d011534
Add note about value param in ad impression event
a-googler Sep 30, 2020
9aecf1e
Add Equals to the JNI Object proxy.
wilhuff Sep 30, 2020
f0a9d5b
Merge remote-tracking branch 'origin/master' into ghm
a-maurice Sep 30, 2020
b0520d8
Add a cache of Firestore Java references to FirestoreInternal pointers
wilhuff Sep 30, 2020
269c554
Update to the Messaging Library Manifest File which caused build issu…
DellaBitta Oct 1, 2020
e0db37f
Automated g4 rollback of changelist 333356092.
var-const Oct 5, 2020
a8b8b98
Remove FirestoreInternal::Wrap and Internal
wilhuff Oct 7, 2020
0ab7887
Convert FieldValue to the new JNI framework
wilhuff Oct 8, 2020
60c1868
Convert Wrapper to the new JNI framework
wilhuff Oct 8, 2020
60e26a1
Reduce dependencies on app's util_android.h
wilhuff Oct 8, 2020
2bdf3e8
Post-migration clean-up
wilhuff Oct 8, 2020
219658d
Reorganize utilities
wilhuff Oct 8, 2020
6031b23
[FIS]CPP package change (8/n)
Oct 9, 2020
c22377a
Fix a deadlock between snapshot listeners and cleanup.
var-const Oct 12, 2020
2b802a1
Update the version numbers to 6.16.1
a-maurice Oct 14, 2020
f278b61
Added helper function to create directories recursively on desktop pl…
a-googler Oct 14, 2020
180bfea
Remove the call from Database to variant_utils that take Flexbuffers
a-maurice Oct 17, 2020
675c6d3
Remove the dependency on variant_util from Database
a-maurice Oct 19, 2020
a65e743
[FIS] mark IID deprecated
Oct 20, 2020
d201e1d
Import Firestore release 1.19.0 from GitHub (Firebase 6.34.0, M81).
var-const Oct 21, 2020
601deb1
Make Android's FirestoreException match iOS
wilhuff Oct 27, 2020
4f20af6
[M82]Update android dependencies
Oct 27, 2020
fb8deaa
[RemoteConfig V2] update api deprecation for Fireconf
Oct 27, 2020
b49acc2
Update the Build and Podfiles for 7.0.0
a-maurice Oct 27, 2020
c4ea71c
Removing deprecated Send and Direct Channel functionality
a-maurice Oct 27, 2020
99cb085
[FCM]Add GetToken, DeleteToken function
Oct 28, 2020
0dbfb8a
[M82]Fix an RC change that fails build unity
Oct 28, 2020
f168c3e
Updated the raw_data field in messaging.h to be a vector of bytes ins…
a-maurice Oct 29, 2020
4cbaaf8
Remove deprecated SetMinimumSessionDuration in Analytics
a-maurice Oct 29, 2020
f825917
Update the version numbers to 7.0.0
a-maurice Nov 2, 2020
b2e2751
Automated g4 rollback of changelist 335476967.
var-const Nov 2, 2020
71dfd15
Port WhereNotEqualTo and WhereNotIn to C++ SDK
wu-hui Nov 4, 2020
67f3520
LSC: Add absl::GetFlag and absl::SetFlag to uses of some flags so the…
a-googler Nov 4, 2020
3cd6c83
[Unity] Port NotEqual and NotIn Queries to Unity SDK
wu-hui Nov 6, 2020
1e5ce8a
Add support for setting and retrieving the cache size to `Settings`.
var-const Nov 7, 2020
62fe4cd
#cleanup Unable to fix after @UiThread or runOnMainSync
a-googler Nov 9, 2020
a2eee76
[FIS]Add unit test for getId, getToken, delete
Nov 9, 2020
eec81e7
Make `Query` methods that return new queries (e.g. `WhereEqualTo`) co…
var-const Nov 9, 2020
8739652
Remove deprecated Dynamic Links properties in C++ and Unity SDK
chkuang-g Nov 10, 2020
c1af0e5
Extract the has-exceptions test into a common header
wilhuff Nov 11, 2020
bda1c10
Implement Firebase Heartbeat in C++.
var-const Nov 12, 2020
87928a7
Fix Unity Editor hang on Windows when Listen() is invoked (b/172566004).
a-googler Nov 12, 2020
b06e164
Fix Android crash when Firestore is disposed during a transaction cal…
a-googler Nov 12, 2020
dae6e76
Copybara Firestore
a-googler Nov 13, 2020
4fdf225
Re-write the transaction logic to run the user-supplied callback asyn…
a-googler Nov 17, 2020
06b4fea
Clean up `Firestore` instance management.
a-googler Nov 20, 2020
f4e8858
Remove unnecessary std before strlen, as it causes problems
a-maurice Nov 21, 2020
16060f5
Update Integration and Testapp minimum target iOS version to fix rapi…
DellaBitta Nov 21, 2020
2e784e8
A second update to the integration and testapp XCode projects to bump…
DellaBitta Nov 23, 2020
fb2201f
Automated g4 rollback of changelist 343888975.
DellaBitta Nov 25, 2020
381d3a4
Fix invalid conversion from AuthError to a Firestore Error.
a-googler Nov 30, 2020
6ebbd36
Fix AdMob Android to initialize JavaVM earlier in initialization.
jonsimantov Nov 30, 2020
a4b572b
Fix 1 ClangTidyReadability finding:
a-googler Dec 2, 2020
538623c
Fix memory leaks in ReleaseXArrayElements:
a-googler Dec 3, 2020
30f9bf7
Fix bug where including a "delete" operation in an update causes part…
a-googler Dec 4, 2020
f4f119e
[M82][RemoteConfig] Remove deprecated android apis in 7.0.0
Dec 5, 2020
b1ba676
Merge remote-tracking branch 'origin/master' into ghm
a-maurice Dec 9, 2020
e2ecd1e
Merge 7.0.0 release from main to dev. Resolving 123 merge conflicts.
DellaBitta Dec 10, 2020
ccd86e3
Adding play services base to app resources
DellaBitta Dec 10, 2020
306484f
removed deleted src/ios/firebase_firestore_settings_ios files
DellaBitta Dec 10, 2020
681fe39
update ios target version
DellaBitta Dec 10, 2020
8a64982
move play-services-base to google_api_resources build.gradle
DellaBitta Dec 10, 2020
a4bcc71
fixed version control conflict marker
DellaBitta Dec 10, 2020
8d15724
Search headers in xcframework path
sunmou99 Dec 10, 2020
af24515
fail if build subprocess fail
sunmou99 Dec 11, 2020
892a248
fixing merge conflict remnant
DellaBitta Dec 11, 2020
d20f8db
Merge branch 'merge-m83' of github.com:firebase/firebase-cpp-sdk into…
DellaBitta Dec 11, 2020
95ae637
add gPRC dependency
sunmou99 Dec 11, 2020
e74d269
build fail when subprocess fail
sunmou99 Dec 11, 2020
fa167a2
Update podfile in iOS integration test as well
sunmou99 Dec 12, 2020
a736153
Build fixes for dev branch (#210)
DellaBitta Dec 14, 2020
dd3ff59
Firestore Dependency update & gmock include fix (#214)
DellaBitta Dec 15, 2020
2dc38f3
Merge branch 'dev' into merge-m83
DellaBitta Dec 15, 2020
7e66247
added release notes
DellaBitta Dec 15, 2020
a7342a8
Fixes for packaging steps (#215)
DellaBitta Dec 16, 2020
e8d515b
Merge branch 'dev' into merge-m83
DellaBitta Dec 16, 2020
1515717
Merge branch 'dev' into merge-m83
jonsimantov Dec 16, 2020
6b7c028
Merge branch 'dev' into merge-m83
DellaBitta Dec 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions Android/firebase_dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,28 @@ import org.gradle.util.ConfigureUtil;

// A map of library to the dependencies that need to be added for it.
def firebaseDependenciesMap = [
'app' : ['com.google.firebase:firebase-analytics:17.5.0'],
'admob' : ['com.google.firebase:firebase-ads:19.3.0',
'com.google.android.gms:play-services-measurement-sdk-api:17.5.0',
'com.google.android.gms:play-services-base:17.4.0'],
'analytics' : ['com.google.firebase:firebase-analytics:17.5.0',
'com.google.android.gms:play-services-base:17.4.0'],
'auth' : ['com.google.firebase:firebase-auth:19.3.2'],
'database' : ['com.google.firebase:firebase-database:19.4.0'],
'dynamic_links' : ['com.google.firebase:firebase-dynamic-links:19.1.0'],
'firestore' : ['com.google.firebase:firebase-firestore:21.6.0'],
'app' : ['com.google.firebase:firebase-analytics:18.0.0'],
'admob' : ['com.google.firebase:firebase-ads:19.5.0',
'com.google.android.gms:play-services-measurement-sdk-api:18.0.0',
'com.google.android.gms:play-services-base:17.5.0'],
'analytics' : ['com.google.firebase:firebase-analytics:18.0.0',
'com.google.android.gms:play-services-base:17.5.0'],
'auth' : ['com.google.firebase:firebase-auth:20.0.0'],
'database' : ['com.google.firebase:firebase-database:19.5.1'],
'dynamic_links' : ['com.google.firebase:firebase-dynamic-links:19.1.1'],
'firestore' : ['com.google.firebase:firebase-firestore:22.0.0'],
'functions' : ['com.google.firebase:firebase-functions:19.1.0'],
'instance_id' : ['com.google.firebase:firebase-iid:20.2.4'],
'installations' : ['com.google.firebase:firebase-installations:16.3.3',
'com.google.android.gms:play-services-base:17.4.0'],
'instance_id' : ['com.google.firebase:firebase-iid:21.0.0'],
'invites' : ['com.google.firebase:firebase-invites:17.0.0'],
// Messaging has an additional local dependency to include.
'messaging' : ['com.google.firebase:firebase-messaging:20.2.4',
'messaging' : ['com.google.firebase:firebase-messaging:21.0.0',
'firebase_cpp_sdk.messaging:messaging_java',
'androidx.core:core:1.0.1'],
'performance' : ['com.google.firebase:firebase-perf:19.0.8'],
'remote_config' : ['com.google.firebase:firebase-config:19.2.0',
'com.google.android.gms:play-services-base:17.4.0'],
'performance' : ['com.google.firebase:firebase-perf:19.0.9'],
'remote_config' : ['com.google.firebase:firebase-config:20.0.0',
'com.google.android.gms:play-services-base:17.5.0'],
'storage' : ['com.google.firebase:firebase-storage:19.2.0']
]

Expand Down
6 changes: 3 additions & 3 deletions admob/admob_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ android {
}

dependencies {
implementation 'com.google.firebase:firebase-analytics:17.5.0'
implementation 'com.google.firebase:firebase-ads:19.3.0'
implementation 'com.google.firebase:firebase-analytics:18.0.0'
implementation 'com.google.firebase:firebase-ads:19.5.0'
}

afterEvaluate {
generateReleaseBuildConfig.enabled = false
}

apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
extractAndDexAarFile('admob_resources')
extractAndDexAarFile('admob_resources')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:newline at end of file

5 changes: 4 additions & 1 deletion admob/src/android/admob_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ InitResult Initialize(JNIEnv* env, jobject activity) {
}

InitResult Initialize(JNIEnv* env, jobject activity, const char* admob_app_id) {
if (g_java_vm == nullptr) {
env->GetJavaVM(&g_java_vm);
}

// AdMob requires Google Play services if the class
// "com.google.android.gms.ads.internal.ClientApi" does not exist.
if (!util::FindClass(env, "com/google/android/gms/ads/internal/ClientApi") &&
Expand Down Expand Up @@ -192,7 +196,6 @@ InitResult Initialize(JNIEnv* env, jobject activity, const char* admob_app_id) {

g_initialized = true;
g_activity = env->NewGlobalRef(activity);
env->GetJavaVM(&g_java_vm);

InitializeGoogleMobileAds(env, admob_app_id);
RegisterTerminateOnDefaultAppDestroy();
Expand Down
6 changes: 3 additions & 3 deletions admob/tools/ios/testapp/testapp.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 9.3;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
OTHER_CFLAGS = (
Expand Down Expand Up @@ -456,7 +456,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 9.3;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
MTL_ENABLE_DEBUG_INFO = NO;
OTHER_CFLAGS = (
"$(inherited)",
Expand All @@ -476,7 +476,7 @@
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImages;
DEVELOPMENT_TEAM = "";
INFOPLIST_FILE = testapp/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.google.ios.admob.testapp;
PRODUCT_NAME = testapp;
Expand Down
6 changes: 0 additions & 6 deletions analytics/src/analytics_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,6 @@ void SetUserId(const char* user_id) {
if (user_id_value) env->DeleteLocalRef(user_id_value);
}

// Sets the minimum engagement time required before starting a session.
void SetMinimumSessionDuration(int64_t milliseconds) {
LogWarning(
"SetMinimumSessionDuration is deprecated and no longer functional.");
}

// Sets the duration of inactivity that terminates the current session.
void SetSessionTimeoutDuration(int64_t milliseconds) {
FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
Expand Down
6 changes: 0 additions & 6 deletions analytics/src/analytics_ios.mm
Original file line number Diff line number Diff line change
Expand Up @@ -236,12 +236,6 @@ void SetUserId(const char* user_id) {
[FIRAnalytics setUserID:(user_id ? @(user_id) : nil)];
}

// Sets the minimum engagement time required before starting a session.
// (No longer functional.)
void SetMinimumSessionDuration(int64_t milliseconds) {
LogWarning("SetMinimumSessionDuration is deprecated and no longer functional.");
}

// Sets the duration of inactivity that terminates the current session.
void SetSessionTimeoutDuration(int64_t milliseconds) {
FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
Expand Down
5 changes: 0 additions & 5 deletions analytics/src/analytics_stub.cc
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,6 @@ void SetUserId(const char* /*user_id*/) {
FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
}

// Sets the minimum engagement time required before starting a session.
void SetMinimumSessionDuration(int64_t /*milliseconds*/) {
FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
}

// Sets the duration of inactivity that terminates the current session.
void SetSessionTimeoutDuration(int64_t /*milliseconds*/) {
FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
Expand Down
11 changes: 0 additions & 11 deletions analytics/src/include/firebase/analytics.h
Original file line number Diff line number Diff line change
Expand Up @@ -489,17 +489,6 @@ void SetUserProperty(const char* name, const char* property);
/// Setting user_id to NULL or nullptr removes the user ID.
void SetUserId(const char* user_id);

/// @brief Sets the minimum engagement time required before starting a session.
///
/// @note The default value is 10000 (10 seconds).
///
/// @param milliseconds The minimum engagement time required to start a new
/// session.
///
/// @deprecated SetMinimumSessionDuration is deprecated and no longer
/// functional.
FIREBASE_DEPRECATED void SetMinimumSessionDuration(int64_t milliseconds);

/// @brief Sets the duration of inactivity that terminates the current session.
///
/// @note The default value is 1800000 (30 minutes).
Expand Down
10 changes: 10 additions & 0 deletions app/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,15 @@ set(app_android_SRCS
set(app_ios_SRCS
src/app_ios.mm
src/util_ios.mm
src/heartbeat_date_storage_desktop.cc
src/heartbeat_info_desktop.cc
src/invites/ios/invites_receiver_internal_ios.mm
src/invites/ios/invites_ios_startup.mm
src/uuid_ios_darwin.mm)
set(app_desktop_SRCS
src/app_desktop.cc
src/heartbeat_date_storage_desktop.cc
src/heartbeat_info_desktop.cc
src/invites/stub/invites_receiver_internal_stub.cc
src/variant_util.cc)
if(ANDROID)
Expand All @@ -179,11 +183,13 @@ else()
if(MSVC)
set(app_desktop_extra_SRCS
src/secure/user_secure_windows_internal.cc
src/filesystem_desktop_windows.cc
src/locale.cc
src/uuid.cc)
elseif(APPLE)
set(app_desktop_extra_SRCS
src/secure/user_secure_darwin_internal.mm
src/filesystem_apple.mm
src/locale_apple.mm
src/uuid_ios_darwin.mm)
else()
Expand All @@ -202,6 +208,7 @@ else()
endif()
set(app_desktop_extra_SRCS
src/secure/user_secure_linux_internal.cc
src/filesystem_desktop_linux.cc
src/locale.cc
src/uuid.cc)
endif()
Expand Down Expand Up @@ -230,10 +237,13 @@ set(utility_common_HDRS
src/callback.h
src/cleanup_notifier.h
src/embedded_file.h
src/filesystem.h
src/function_registry.h
src/future_manager.h
src/intrusive_list.h
src/log.h
src/heartbeat_date_storage_desktop.h
src/heartbeat_info_desktop.h
src/mutex.h
src/optional.h
src/path.h
Expand Down
4 changes: 2 additions & 2 deletions app/app_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ android {
}

dependencies {
implementation 'com.google.firebase:firebase-analytics:17.5.0'
implementation 'com.google.firebase:firebase-analytics:18.0.0'
}

afterEvaluate {
generateReleaseBuildConfig.enabled = false
}

apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
extractAndDexAarFile('app_resources')
extractAndDexAarFile('app_resources')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:newline at end of file

6 changes: 3 additions & 3 deletions app/google_api_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ android {
}

dependencies {
implementation 'com.google.firebase:firebase-analytics:17.5.0'
implementation 'com.google.android.gms:play-services-base:17.0.0'
implementation 'com.google.firebase:firebase-analytics:18.0.0'
implementation 'com.google.android.gms:play-services-base:17.5.0'
implementation project(':app:app_resources')
}

Expand All @@ -59,4 +59,4 @@ afterEvaluate {
}

apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
extractAndDexAarFile('google_api_resources')
extractAndDexAarFile('google_api_resources')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:newline at end of file

6 changes: 3 additions & 3 deletions app/invites_resources/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ android {
}

dependencies {
implementation 'com.google.firebase:firebase-analytics:17.5.0'
implementation 'com.google.firebase:firebase-dynamic-links:19.1.0'
implementation 'com.google.firebase:firebase-analytics:18.0.0'
implementation 'com.google.firebase:firebase-dynamic-links:19.1.1'
implementation project(':app:app_resources')
}

Expand All @@ -55,4 +55,4 @@ afterEvaluate {
}

apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
extractAndDexAarFile('invites_resources')
extractAndDexAarFile('invites_resources')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:newline at end of file

6 changes: 4 additions & 2 deletions app/rest/tests/request_file_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,17 @@
* limitations under the License.
*/

#include "app/rest/request_file.h"

#include <stdio.h>

#include <cstddef>
#include <string>

#include "app/rest/request_file.h"
#include "app/rest/tests/request_test.h"
#include "gtest/gtest.h"
#include "gmock/gmock.h"
#include "absl/flags/flag.h"

namespace firebase {
namespace rest {
Expand All @@ -31,7 +33,7 @@ namespace test {
class RequestFileTest : public ::testing::Test {
public:
RequestFileTest()
: filename_(FLAGS_test_tmpdir + "/a_file.txt"),
: filename_(absl::GetFlag(FLAGS_test_tmpdir) + "/a_file.txt"),
file_(nullptr),
file_size_(0) {}

Expand Down
7 changes: 7 additions & 0 deletions app/src/app_common.cc
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,14 @@ const char* kCppRuntimeOrStl = "libcpp";

#elif FIREBASE_PLATFORM_LINUX
const char* kOperatingSystem = "linux";

#if defined(_GLIBCXX_UTILITY)
const char* kCppRuntimeOrStl = "gnustl";
#elif defined(_LIBCPP_STD_VER)
const char* kCppRuntimeOrStl = "libcpp";
#else
#error Unknown Linux STL.
#endif // STL

#if __amd64__
const char* kCpuArchitecture = "x86_64";
Expand Down
63 changes: 63 additions & 0 deletions app/src/filesystem.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#ifndef FIREBASE_APP_CLIENT_CPP_SRC_FILESYSTEM_H_
#define FIREBASE_APP_CLIENT_CPP_SRC_FILESYSTEM_H_

#include <string>

#if !defined(FIREBASE_NAMESPACE)
#define FIREBASE_NAMESPACE firebase
#endif

namespace FIREBASE_NAMESPACE {

/**
* Returns a system-defined best directory in which to create application
* data. Values vary wildly across platforms. They include:
*
* * iOS: $container/Library/Application Support/$app_name
* * Linux: $HOME/.local/share/$app_name
* * macOS: $container/Library/Application Support/$app_name
* * Other UNIX: $HOME/.$app_name. Note: Android is not implemented yet.
* * tvOS: $container/Library/Caches/$app_name
* * Windows: %USERPROFILE%/AppData/Local
*
* On iOS, tvOS, and macOS (when running sandboxed), these locations are
* relative to the data container for the current application. On macOS when
* the application is not sandboxed, the returned value will be relative to
* $HOME instead. See "About the iOS File System" in the Apple "File System
* Programming Guide" at https://apple.co/2Nn7Bsb.
*
* Note: the returned path is just where the system thinks the application
* data should be stored, but `AppDataDir` does not actually guarantee that this
* path exists (unless `should_create` is `true`, in which case it will attempt
* to create a directory at the given path).
*
* @param app_name The name of the application.
* @return The path to the application data, or an empty string if an error
* occurred.
*/
// TODO(varconst): Android is currently not supported.
//
// TODO(b/171738655): use a separate function instead of the `should_create`
// flag. Use `StatusOr` for returning errors.
std::string AppDataDir(const char* app_name, bool should_create = true,
std::string* out_error = nullptr);

} // namespace FIREBASE_NAMESPACE

#endif // FIREBASE_APP_CLIENT_CPP_SRC_FILESYSTEM_H_
Loading