Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port FSTListenOptions to C++ #2617

Merged
merged 18 commits into from
Mar 26, 2019
Merged

Port FSTListenOptions to C++ #2617

merged 18 commits into from
Mar 26, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Mar 24, 2019

Note the DIFFBASE on #2608.

wilhuff added 15 commits March 21, 2019 15:09
@wilhuff
Replace FSTDocumentSet's guts with immutable::SortedSet.
433fec1
@wilhuff
Port FSTDocumentSet to C++ DocumentSet.
83d61c7
@wilhuff
Replace implementation of FSTDocumentSet with C++ DocumentSet
5666ce5
@wilhuff
Update all usages of FSTDocumentSet
83c0687
@wilhuff
Remove FSTDocumentSet
614132f
@wilhuff
Merge branch 'master' into wilhuff/document-set
d648e35
@wilhuff
Add Objective-C++ guard
f46866c
@wilhuff
Use absl::c_equal instead of hand-rolling it.
3f45e44
@wilhuff
Split SortedContainer out of SortedMapBase
c4fbcfe 
... and use it
@wilhuff
Remove = default constructors that aren't true.
114fe05 
These are implicitly deleted because DocumentSet is a member and isn't
default constructible.
@wilhuff
Fix NSNotFound -> npos
03847dc
@wilhuff
Fix usage of FSTQuery.limit
9d86b35
@wilhuff
Port FSTListenOptions to C++
5cbe0ea
@wilhuff
Remove usage of FSTListenOptions
b2116b3
@wilhuff
Remove FSTListenOptions
59da887
@wilhuff wilhuff requested a review from mikelehen March 24, 2019 16:48
@wilhuff wilhuff mentioned this pull request Mar 24, 2019
Merged
mikelehen
mikelehen approved these changes Mar 24, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment nits

Firestore/core/src/firebase/firestore/core/listen_options.h Outdated Show resolved Hide resolved
Firestore/core/src/firebase/firestore/core/listen_options.h Outdated Show resolved Hide resolved
Firestore/core/src/firebase/firestore/core/listen_options.h Outdated Show resolved Hide resolved
@mikelehen mikelehen assigned wilhuff and unassigned mikelehen Mar 24, 2019
@wilhuff wilhuff changed the base branch from wilhuff/document-set to master March 25, 2019 18:13
@wilhuff wilhuff merged commit ce07f8d into master Mar 26, 2019
@wilhuff wilhuff deleted the wilhuff/listen-options branch March 26, 2019 03:35
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@wilhuff @Corrob
Port FSTListenOptions to C++ (#2617)
ee58ec3
@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@wilhuff wilhuff

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilhuff @mikelehen @googlebot