Port FSTQueryListener to C++ #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and use it
These are implicitly deleted because DocumentSet is a member and isn't default constructible.
var-const
approved these changes
Mar 25, 2019
wilhuff
force-pushed
the
wilhuff/query-listener
branch
from
f1f24b9 to
d85bf4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryListener is the core entity that the EventManager retains to maintain a listener on the user's behalf. This needs to be a
std::shared_ptrin order to enable the ListenerRegistration to maintain a weak reference to it.This partially addresses #2564, but the other part is the async listener.
Note the DIFFBASE on #2617.